Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Option to enable tracing level metrics without full tracing #239

Closed
jmccaull opened this issue Apr 22, 2019 · 6 comments
Closed

Option to enable tracing level metrics without full tracing #239

jmccaull opened this issue Apr 22, 2019 · 6 comments

Comments

@jmccaull
Copy link

Is there any opposition to having the option to enable full tracing metrics without having trancing data returned to the consumer? Essentially we would like to have the bean TracingInsturmentation with tracing-enabled still = false

@jmccaull
Copy link
Author

@oliemansm, thoughts? did a quick PR: #240. We would like to replace some of our custom metrics instrumentation with this

@oliemansm
Copy link
Member

I've merged your PR, had no problem with this. Just come to think of it after the merge: could you update the README to document the possible props?

@jmccaull
Copy link
Author

@oliemansm I think this should cover it, lmk if you want any more in depth. Thanks!
#241

@oliemansm
Copy link
Member

@jmccaull That'll do, thanks!

@IvBre
Copy link

IvBre commented Nov 13, 2019

Hello @jmccaull @oliemansm
Thank you for this feature, this is exactly what we need.
I've noticed though that additional-spring-configuration-metadata.json is still expecting a Boolean for graphql.servlet.tracingEnabled field which doesn't allow our application.yml config to set it to metrics-only which is a string. Am I missing something? 🤔
I don't have rights to push to this repo, but the change would be something like this:

additional-spring-configuration-metadata.json:

...
    {
      "name": "graphql.servlet.tracingEnabled",
      "defaultValue": false,
      "type": "java.lang.String"
    },
...

@kijanowski
Copy link

Hello, I've been hit by the same thing and provided a PR: #337

oliemansm added a commit that referenced this issue Feb 6, 2020
…evel-a-string

fix(): make tracingLevel config value a type of String instead of Boolean to fix #239
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants