Skip to content

chore: switch from gob to JSON encoding for digests #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

chore: switch from gob to JSON encoding for digests #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/hash/sha256.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ package hash

import (
"crypto/sha256"
"encoding/gob"
"encoding/hex"
"encoding/json"
)

func ID(parts ...string) string {
Expand All @@ -26,7 +26,7 @@ func Digest(obj any) string {
case string:
hash.Write([]byte(v))
default:
if err := gob.NewEncoder(hash).Encode(obj); err != nil {
if err := json.NewEncoder(hash).Encode(obj); err != nil {
panic(err)
}
}
Expand Down
12 changes: 6 additions & 6 deletions pkg/tests/runner2_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ name: mcp
],
"type": "object"
},
"instructions": "#!sys.mcp.invoke.append_insight c358c2eb93fa9a98631cd9e4f324d7b59f56aee11c7ae32a00984ad5844dc32c",
"instructions": "#!sys.mcp.invoke.append_insight e592cc0c9483290685611ba70bd8595829cc794f7eae0419eabb3388bf0d3529",
"id": "inline:append_insight",
"localTools": {
"append_insight": "inline:append_insight",
Expand Down Expand Up @@ -346,7 +346,7 @@ name: mcp
],
"type": "object"
},
"instructions": "#!sys.mcp.invoke.create_table c358c2eb93fa9a98631cd9e4f324d7b59f56aee11c7ae32a00984ad5844dc32c",
"instructions": "#!sys.mcp.invoke.create_table e592cc0c9483290685611ba70bd8595829cc794f7eae0419eabb3388bf0d3529",
"id": "inline:create_table",
"localTools": {
"append_insight": "inline:append_insight",
Expand Down Expand Up @@ -379,7 +379,7 @@ name: mcp
],
"type": "object"
},
"instructions": "#!sys.mcp.invoke.describe_table c358c2eb93fa9a98631cd9e4f324d7b59f56aee11c7ae32a00984ad5844dc32c",
"instructions": "#!sys.mcp.invoke.describe_table e592cc0c9483290685611ba70bd8595829cc794f7eae0419eabb3388bf0d3529",
"id": "inline:describe_table",
"localTools": {
"append_insight": "inline:append_insight",
Expand All @@ -403,7 +403,7 @@ name: mcp
"arguments": {
"type": "object"
},
"instructions": "#!sys.mcp.invoke.list_tables c358c2eb93fa9a98631cd9e4f324d7b59f56aee11c7ae32a00984ad5844dc32c",
"instructions": "#!sys.mcp.invoke.list_tables e592cc0c9483290685611ba70bd8595829cc794f7eae0419eabb3388bf0d3529",
"id": "inline:list_tables",
"localTools": {
"append_insight": "inline:append_insight",
Expand Down Expand Up @@ -505,7 +505,7 @@ name: mcp
],
"type": "object"
},
"instructions": "#!sys.mcp.invoke.read_query c358c2eb93fa9a98631cd9e4f324d7b59f56aee11c7ae32a00984ad5844dc32c",
"instructions": "#!sys.mcp.invoke.read_query e592cc0c9483290685611ba70bd8595829cc794f7eae0419eabb3388bf0d3529",
"id": "inline:read_query",
"localTools": {
"append_insight": "inline:append_insight",
Expand Down Expand Up @@ -538,7 +538,7 @@ name: mcp
],
"type": "object"
},
"instructions": "#!sys.mcp.invoke.write_query c358c2eb93fa9a98631cd9e4f324d7b59f56aee11c7ae32a00984ad5844dc32c",
"instructions": "#!sys.mcp.invoke.write_query e592cc0c9483290685611ba70bd8595829cc794f7eae0419eabb3388bf0d3529",
"id": "inline:write_query",
"localTools": {
"append_insight": "inline:append_insight",
Expand Down