Skip to content

Use error wrapping in Go 1.13 #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ianlewis opened this issue Mar 26, 2020 · 18 comments
Open

Use error wrapping in Go 1.13 #2270

ianlewis opened this issue Mar 26, 2020 · 18 comments
Labels
good first issue Good for newcomers priority: p3 Low priority status: help wanted Extra attention is needed type: cleanup Refactorings and cleanups to improve the code

Comments

@ianlewis
Copy link
Contributor

Make use of the new error wrapping functionality and API to be able to check error types easier.

https://blog.golang.org/go1.13-errors

@ianlewis ianlewis added type: cleanup Refactorings and cleanups to improve the code priority: p3 Low priority labels Mar 26, 2020
copybara-service bot pushed a commit that referenced this issue Apr 8, 2020
@ianlewis ianlewis self-assigned this Jun 9, 2021
@ianlewis ianlewis added good first issue Good for newcomers status: help wanted Extra attention is needed labels Jun 10, 2021
@Yuya9786
Copy link

Yuya9786 commented Feb 8, 2022

@ianlewis I want to try this issue. But I don't know where to start because this issue is related to all sorts of codes in this project. And I'm not familiar to the details of gVisor but I know what this issue expects. Could you guide me in a bit?

@ianlewis
Copy link
Contributor Author

ianlewis commented Feb 8, 2022

@Yuya9786 It shouldn't be too involved. This is really just a placeholder issue to use "%w" style formatting directives rather than "%v" for errors when calling fmt.Errorf. So rather than this:

return fmt.Errorf("some error: %v", err)

The code would look like this

return fmt.Errorf("some error: %w", err)

You can search for some places where fmt.Errorf is used here: https://github.com/google/gvisor/search?q=fmt.Errorf

@Yuya9786
Copy link

Yuya9786 commented Feb 8, 2022

I got it. I'll fix all fmt.Errorfs' "%v" to "%w" .

@ryo-yamaoka
Copy link

@Yuya9786 Excuse me, are you still working on this issue?
If not, may I would like to take over this?

Yuya9786 added a commit to Yuya9786/gvisor that referenced this issue Mar 14, 2022
@Yuya9786
Copy link

Yuya9786 commented Mar 14, 2022

@ryo-yamaoka I've already done to fix and succeeded to build, but I couldn't succeed to test because of timeout.
Maybe the cause is that my laptop specs are not good enough.
Would you be willing to test instead of me?

@ryo-yamaoka
Copy link

ryo-yamaoka commented Mar 14, 2022

@Yuya9786 I tried high spec machine, then succeeded to build and unit-tests, and failed nogo-tests into make tests.
The reason for the failure seems to be different (There appears to be no timeout log.), but the bazel logs disappeared and I couldn't see them...
Is it also nogo-tests that you failed?

SPEC of build environment

  • CPU: 32 core
  • Mem: 32GB
  • Disk: 50GB
$ sudo make copy TARGETS=runsc DESTINATION=bin/

(omission middle part)

INFO: Analyzed target //runsc:runsc (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
INFO: Elapsed time: 0.417s
INFO: 0 processes.
INFO: Build completed successfully, 0 total actions
INFO: Build completed successfully, 0 total actions
$ sudo make unit-tests

(omission middle part)

//pkg/tcpip/stack:stack_x_test                                           PASSED in 0.1s
  Stats over 8 runs: max = 0.1s, min = 0.1s, avg = 0.1s, dev = 0.0s

Executed 224 out of 224 tests: 224 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
INFO: Build completed successfully, 7754 total actions
INFO: Build Event Protocol files produced successfully.
INFO: Build completed successfully, 7754 total actions
make tests (so big log!)
$ sudo make tests

(omission middle part)

//tools/yamltest:yamltest_nogo                                           PASSED in 0.2s
//pkg/bpf:bpf_nogo                                                       FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/bpf/bpf_nogo/test.log
//pkg/bpf:bpf_test_nogo                                                  FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/bpf/bpf_test_nogo/test.log
//pkg/seccomp:seccomp_nogo                                               FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/seccomp/seccomp_nogo/test.log
//pkg/seccomp:seccomp_test_nogo                                          FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/seccomp/seccomp_test_nogo/test.log
//pkg/sentry/contexttest:contexttest_nogo                                FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/contexttest/contexttest_nogo/test.log
//pkg/sentry/control:control_nogo                                        FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/control/control_nogo/test.log
//pkg/sentry/control:control_test_nogo                                   FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/control/control_test_nogo/test.log
//pkg/sentry/devices/memdev:memdev_nogo                                  FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/devices/memdev/memdev_nogo/test.log
//pkg/sentry/devices/ttydev:ttydev_nogo                                  FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/devices/ttydev/ttydev_nogo/test.log
//pkg/sentry/devices/tundev:tundev_nogo                                  FAILED in 0.7s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/devices/tundev/tundev_nogo/test.log
//pkg/sentry/fdimport:fdimport_nogo                                      FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fdimport/fdimport_nogo/test.log
//pkg/sentry/fs:fs_nogo                                                  FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/fs_nogo/test.log
//pkg/sentry/fs:fs_test_nogo                                             FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/fs_test_nogo/test.log
//pkg/sentry/fs:fs_x_test_nogo                                           FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/fs_x_test_nogo/test.log
//pkg/sentry/fs/anon:anon_nogo                                           FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/anon/anon_nogo/test.log
//pkg/sentry/fs/dev:dev_nogo                                             FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/dev/dev_nogo/test.log
//pkg/sentry/fs/fdpipe:fdpipe_nogo                                       FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/fdpipe/fdpipe_nogo/test.log
//pkg/sentry/fs/fdpipe:fdpipe_test_nogo                                  FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/fdpipe/fdpipe_test_nogo/test.log
//pkg/sentry/fs/filetest:filetest_nogo                                   FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/filetest/filetest_nogo/test.log
//pkg/sentry/fs/fsutil:fsutil_nogo                                       FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/fsutil/fsutil_nogo/test.log
//pkg/sentry/fs/fsutil:fsutil_test_nogo                                  FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/fsutil/fsutil_test_nogo/test.log
//pkg/sentry/fs/gofer:gofer_nogo                                         FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/gofer/gofer_nogo/test.log
//pkg/sentry/fs/gofer:gofer_test_nogo                                    FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/gofer/gofer_test_nogo/test.log
//pkg/sentry/fs/host:host_nogo                                           FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/host/host_nogo/test.log
//pkg/sentry/fs/host:host_test_nogo                                      FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/host/host_test_nogo/test.log
//pkg/sentry/fs/proc:proc_nogo                                           FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/proc/proc_nogo/test.log
//pkg/sentry/fs/proc:proc_test_nogo                                      FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/proc/proc_test_nogo/test.log
//pkg/sentry/fs/proc/seqfile:seqfile_nogo                                FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/proc/seqfile/seqfile_nogo/test.log
//pkg/sentry/fs/proc/seqfile:seqfile_test_nogo                           FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/proc/seqfile/seqfile_test_nogo/test.log
//pkg/sentry/fs/ramfs:ramfs_nogo                                         FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/ramfs/ramfs_nogo/test.log
//pkg/sentry/fs/ramfs:ramfs_test_nogo                                    FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/ramfs/ramfs_test_nogo/test.log
//pkg/sentry/fs/sys:sys_nogo                                             FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/sys/sys_nogo/test.log
//pkg/sentry/fs/timerfd:timerfd_nogo                                     FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/timerfd/timerfd_nogo/test.log
//pkg/sentry/fs/tmpfs:tmpfs_nogo                                         FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/tmpfs/tmpfs_nogo/test.log
//pkg/sentry/fs/tmpfs:tmpfs_test_nogo                                    FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/tmpfs/tmpfs_test_nogo/test.log
//pkg/sentry/fs/tty:tty_nogo                                             FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/tty/tty_nogo/test.log
//pkg/sentry/fs/tty:tty_test_nogo                                        FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/tty/tty_test_nogo/test.log
//pkg/sentry/fs/user:user_nogo                                           FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/user/user_nogo/test.log
//pkg/sentry/fs/user:user_test_nogo                                      FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fs/user/user_test_nogo/test.log
//pkg/sentry/fsbridge:fsbridge_nogo                                      FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsbridge/fsbridge_nogo/test.log
//pkg/sentry/fsimpl/cgroupfs:cgroupfs_nogo                               FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/cgroupfs/cgroupfs_nogo/test.log
//pkg/sentry/fsimpl/cgroupfs:cgroupfs_test_nogo                          FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/cgroupfs/cgroupfs_test_nogo/test.log
//pkg/sentry/fsimpl/devpts:devpts_nogo                                   FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/devpts/devpts_nogo/test.log
//pkg/sentry/fsimpl/devpts:devpts_test_nogo                              FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/devpts/devpts_test_nogo/test.log
//pkg/sentry/fsimpl/devtmpfs:devtmpfs_nogo                               FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/devtmpfs/devtmpfs_nogo/test.log
//pkg/sentry/fsimpl/devtmpfs:devtmpfs_test_nogo                          FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/devtmpfs/devtmpfs_test_nogo/test.log
//pkg/sentry/fsimpl/eventfd:eventfd_nogo                                 FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/eventfd/eventfd_nogo/test.log
//pkg/sentry/fsimpl/eventfd:eventfd_test_nogo                            FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/eventfd/eventfd_test_nogo/test.log
//pkg/sentry/fsimpl/fuse:fuse_nogo                                       FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/fuse/fuse_nogo/test.log
//pkg/sentry/fsimpl/fuse:fuse_test_nogo                                  FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/fuse/fuse_test_nogo/test.log
//pkg/sentry/fsimpl/gofer:gofer_nogo                                     FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/gofer/gofer_nogo/test.log
//pkg/sentry/fsimpl/gofer:gofer_test_nogo                                FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/gofer/gofer_test_nogo/test.log
//pkg/sentry/fsimpl/host:host_nogo                                       FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/host/host_nogo/test.log
//pkg/sentry/fsimpl/kernfs:kernfs_nogo                                   FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/kernfs/kernfs_nogo/test.log
//pkg/sentry/fsimpl/kernfs:kernfs_test_nogo                              FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/kernfs/kernfs_test_nogo/test.log
//pkg/sentry/fsimpl/mqfs:mqfs_nogo                                       FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/mqfs/mqfs_nogo/test.log
//pkg/sentry/fsimpl/overlay:overlay_nogo                                 FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/overlay/overlay_nogo/test.log
//pkg/sentry/fsimpl/pipefs:pipefs_nogo                                   FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/pipefs/pipefs_nogo/test.log
//pkg/sentry/fsimpl/proc:proc_nogo                                       FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/proc/proc_nogo/test.log
//pkg/sentry/fsimpl/proc:proc_test_nogo                                  FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/proc/proc_test_nogo/test.log
//pkg/sentry/fsimpl/signalfd:signalfd_nogo                               FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/signalfd/signalfd_nogo/test.log
//pkg/sentry/fsimpl/sockfs:sockfs_nogo                                   FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/sockfs/sockfs_nogo/test.log
//pkg/sentry/fsimpl/sys:sys_nogo                                         FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/sys/sys_nogo/test.log
//pkg/sentry/fsimpl/sys:sys_test_nogo                                    FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/sys/sys_test_nogo/test.log
//pkg/sentry/fsimpl/testutil:testutil_nogo                               FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/testutil/testutil_nogo/test.log
//pkg/sentry/fsimpl/timerfd:timerfd_nogo                                 FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/timerfd/timerfd_nogo/test.log
//pkg/sentry/fsimpl/tmpfs:benchmark_test_nogo                            FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/tmpfs/benchmark_test_nogo/test.log
//pkg/sentry/fsimpl/tmpfs:tmpfs_nogo                                     FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/tmpfs/tmpfs_nogo/test.log
//pkg/sentry/fsimpl/tmpfs:tmpfs_test_nogo                                FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/tmpfs/tmpfs_test_nogo/test.log
//pkg/sentry/fsimpl/verity:verity_nogo                                   FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/verity/verity_nogo/test.log
//pkg/sentry/fsimpl/verity:verity_test_nogo                              FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/fsimpl/verity/verity_test_nogo/test.log
//pkg/sentry/kernel:kernel_nogo                                          FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/kernel_nogo/test.log
//pkg/sentry/kernel:kernel_test_nogo                                     FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/kernel_test_nogo/test.log
//pkg/sentry/kernel/contexttest:contexttest_nogo                         FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/contexttest/contexttest_nogo/test.log
//pkg/sentry/kernel/epoll:epoll_nogo                                     FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/epoll/epoll_nogo/test.log
//pkg/sentry/kernel/epoll:epoll_test_nogo                                FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/epoll/epoll_test_nogo/test.log
//pkg/sentry/kernel/eventfd:eventfd_nogo                                 FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/eventfd/eventfd_nogo/test.log
//pkg/sentry/kernel/eventfd:eventfd_test_nogo                            FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/eventfd/eventfd_test_nogo/test.log
//pkg/sentry/kernel/fasync:fasync_nogo                                   FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/fasync/fasync_nogo/test.log
//pkg/sentry/kernel/ipc:ipc_nogo                                         FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/ipc/ipc_nogo/test.log
//pkg/sentry/kernel/memevent:memevent_nogo                               FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/memevent/memevent_nogo/test.log
//pkg/sentry/kernel/mq:mq_nogo                                           FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/mq/mq_nogo/test.log
//pkg/sentry/kernel/msgqueue:msgqueue_nogo                               FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/msgqueue/msgqueue_nogo/test.log
//pkg/sentry/kernel/pipe:pipe_nogo                                       FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/pipe/pipe_nogo/test.log
//pkg/sentry/kernel/pipe:pipe_test_nogo                                  FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/pipe/pipe_test_nogo/test.log
//pkg/sentry/kernel/semaphore:semaphore_nogo                             FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/semaphore/semaphore_nogo/test.log
//pkg/sentry/kernel/semaphore:semaphore_test_nogo                        FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/semaphore/semaphore_test_nogo/test.log
//pkg/sentry/kernel/shm:shm_nogo                                         FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/shm/shm_nogo/test.log
//pkg/sentry/kernel/signalfd:signalfd_nogo                               FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/signalfd/signalfd_nogo/test.log
//pkg/sentry/loader:loader_nogo                                          FAILED in 0.4s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/loader/loader_nogo/test.log
//pkg/sentry/mm:mm_nogo                                                  FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/mm/mm_nogo/test.log
//pkg/sentry/mm:mm_test_nogo                                             FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/mm/mm_test_nogo/test.log
//pkg/sentry/platform:platform_nogo                                      FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/platform/platform_nogo/test.log
//pkg/sentry/platform/kvm:kvm_nogo                                       FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/platform/kvm/kvm_nogo/test.log
//pkg/sentry/platform/ptrace:ptrace_nogo                                 FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/platform/ptrace/ptrace_nogo/test.log
//pkg/sentry/socket:socket_nogo                                          FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/socket/socket_nogo/test.log
//pkg/sentry/socket/control:control_nogo                                 FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/socket/control/control_nogo/test.log
//pkg/sentry/socket/control:control_test_nogo                            FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/socket/control/control_test_nogo/test.log
//pkg/sentry/socket/hostinet:hostinet_nogo                               FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/socket/hostinet/hostinet_nogo/test.log
//pkg/sentry/socket/netfilter:netfilter_nogo                             FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/socket/netfilter/netfilter_nogo/test.log
//pkg/sentry/socket/netlink:netlink_nogo                                 FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/socket/netlink/netlink_nogo/test.log
//pkg/sentry/socket/netlink:netlink_test_nogo                            FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/socket/netlink/netlink_test_nogo/test.log
//pkg/sentry/socket/netlink/route:route_nogo                             FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/socket/netlink/route/route_nogo/test.log
//pkg/sentry/socket/netlink/uevent:uevent_nogo                           FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/socket/netlink/uevent/uevent_nogo/test.log
//pkg/sentry/socket/netstack:netstack_nogo                               FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/socket/netstack/netstack_nogo/test.log
//pkg/sentry/socket/unix:unix_nogo                                       FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/socket/unix/unix_nogo/test.log
//pkg/sentry/state:state_nogo                                            FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/state/state_nogo/test.log
//pkg/sentry/strace:strace_nogo                                          FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/strace/strace_nogo/test.log
//pkg/sentry/syscalls:syscalls_nogo                                      FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/syscalls/syscalls_nogo/test.log
//pkg/sentry/syscalls/linux:linux_nogo                                   FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/syscalls/linux/linux_nogo/test.log
//pkg/sentry/syscalls/linux/vfs2:vfs2_nogo                               FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/syscalls/linux/vfs2/vfs2_nogo/test.log
//pkg/sentry/vfs:vfs_nogo                                                FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/vfs/vfs_nogo/test.log
//pkg/sentry/vfs:vfs_test_nogo                                           FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/vfs/vfs_test_nogo/test.log
//pkg/sentry/vfs/memxattr:memxattr_nogo                                  FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/vfs/memxattr/memxattr_nogo/test.log
//pkg/sentry/watchdog:watchdog_nogo                                      FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/watchdog/watchdog_nogo/test.log
//pkg/shim:shim_nogo                                                     FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/shim/shim_nogo/test.log
//pkg/shim:shim_test_nogo                                                FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/shim/shim_test_nogo/test.log
//pkg/tcpip/adapters/gonet:gonet_nogo                                    FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/tcpip/adapters/gonet/gonet_nogo/test.log
//pkg/tcpip/adapters/gonet:gonet_test_nogo                               FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/tcpip/adapters/gonet/gonet_test_nogo/test.log
//pkg/tcpip/link/sharedmem:sharedmem_server_test_nogo                    FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/tcpip/link/sharedmem/sharedmem_server_test_nogo/test.log
//pkg/tcpip/sample/tun_tcp_connect:tun_tcp_connect_nogo                  FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/tcpip/sample/tun_tcp_connect/tun_tcp_connect_nogo/test.log
//pkg/tcpip/stack:stack_test_nogo                                        FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/tcpip/stack/stack_test_nogo/test.log
//pkg/tcpip/stack:stack_x_test_nogo                                      FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/tcpip/stack/stack_x_test_nogo/test.log
//pkg/tcpip/tests/integration:istio_test_nogo                            FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/tcpip/tests/integration/istio_test_nogo/test.log
//pkg/tcpip/transport/tcp/test/e2e:tcp_noracedetector_test_nogo          FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/tcpip/transport/tcp/test/e2e/tcp_noracedetector_test_nogo/test.log
//pkg/tcpip/transport/tcp/test/e2e:tcp_rack_test_nogo                    FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/tcpip/transport/tcp/test/e2e/tcp_rack_test_nogo/test.log
//pkg/tcpip/transport/tcp/test/e2e:tcp_sack_test_nogo                    FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/tcpip/transport/tcp/test/e2e/tcp_sack_test_nogo/test.log
//pkg/tcpip/transport/tcp/test/e2e:tcp_test_nogo                         FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/tcpip/transport/tcp/test/e2e/tcp_test_nogo/test.log
//pkg/test/criutil:criutil_nogo                                          FAILED in 0.1s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/test/criutil/criutil_nogo/test.log
//pkg/test/dockerutil:dockerutil_nogo                                    FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/test/dockerutil/dockerutil_nogo/test.log
//pkg/test/dockerutil:profile_test_nogo                                  FAILED in 0.2s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/test/dockerutil/profile_test_nogo/test.log
//pkg/test/testutil:testutil_nogo                                        FAILED in 0.3s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/test/testutil/testutil_nogo/test.log

Executed 429 out of 429 tests: 297 tests pass and 132 fail locally.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
INFO: Build Event Protocol files produced successfully.
INFO: Build completed, 132 tests FAILED, 2802 total actions
INFO: Build completed, 132 tests FAILED, 2802 total actions
Makefile:199: recipe for target 'nogo-tests' failed
make: *** [nogo-tests] Error 3
$ sudo cat /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/test/testutil/testutil_nogo/test.log
cat: /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/test/testutil/testutil_nogo/test.log: No such file or directory

@ryo-yamaoka
Copy link

By the way, when I run make nogo-tests I get a lot of errors like the following.
You may want to fix this first.

================================================================================
FAIL: //pkg/sentry/kernel/shm:shm_nogo (see /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/pkg/sentry/kernel/shm/shm_nogo/test.log)
INFO: From Testing //pkg/sentry/kernel/shm:shm_nogo:
==================== Test output for //pkg/sentry/kernel/shm:shm_nogo:
printf: pkg/bpf/decoder.go:69:10: fmt.Errorf format %w has arg inst of wrong type gvisor.dev/gvisor/pkg/abi/linux.BPFInstruction
printf: pkg/bpf/decoder.go:98:10: fmt.Errorf format %w has arg inst of wrong type gvisor.dev/gvisor/pkg/abi/linux.BPFInstruction
printf: pkg/bpf/decoder.go:112:10: fmt.Errorf format %w has arg inst of wrong type gvisor.dev/gvisor/pkg/abi/linux.BPFInstruction
printf: pkg/bpf/decoder.go:131:10: fmt.Errorf format %w has arg inst of wrong type gvisor.dev/gvisor/pkg/abi/linux.BPFInstruction
printf: pkg/bpf/decoder.go:167:10: fmt.Errorf format %w has arg inst of wrong type gvisor.dev/gvisor/pkg/abi/linux.BPFInstruction
printf: pkg/bpf/decoder.go:179:10: fmt.Errorf format %w has arg inst of wrong type gvisor.dev/gvisor/pkg/abi/linux.BPFInstruction
printf: pkg/bpf/decoder.go:203:11: fmt.Errorf format %w has arg inst of wrong type gvisor.dev/gvisor/pkg/abi/linux.BPFInstruction
printf: pkg/bpf/decoder.go:234:10: fmt.Errorf format %w has arg inst of wrong type gvisor.dev/gvisor/pkg/abi/linux.BPFInstruction
printf: pkg/bpf/decoder.go:247:10: fmt.Errorf format %w has arg inst of wrong type gvisor.dev/gvisor/pkg/abi/linux.BPFInstruction
================================================================================

@Yuya9786
Copy link

@ryo-yamaoka Thank you for pointing out my mistakes, I fixed these.
I tried to test (make unit-tests and make tests) again,
and then unit-tests was succeeded but whole tests wasn't as well you.
But I can see these failed test.log like following.

exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //pkg/sentry/fdimport:fdimport_nogo
-----------------------------------------------------------------------------
printf: pkg/sentry/socket/netstack/stack.go:470:10: fmt.Errorf format %w has arg err of wrong type gvisor.dev/gvisor/pkg/tcpip.Error
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //pkg/sentry/control:control_nogo
-----------------------------------------------------------------------------
printf: pkg/sentry/socket/netstack/stack.go:470:10: fmt.Errorf format %w has arg err of wrong type gvisor.dev/gvisor/pkg/tcpip.Error

There are many errors because of same reason.
tcpip.Error is different from standard error and doesn't have Error() function.
I think That's why these error occur.
But I'm not sure very well because I'm not familiar to Golang's detail.
So could you check it?

I posted same content in my pull request. (#7285 (comment))

@Yuya9786
Copy link

I fixed it and then succeeded unit-tests and nogo-tests.
But I didn't succeed container-tests and syscall-tests because of timeout.

@ryo-yamaoka
Copy link

ryo-yamaoka commented Mar 17, 2022

Okay thanks, I'll check tonight

@ryo-yamaoka
Copy link

ryo-yamaoka commented Mar 17, 2022

@Yuya9786 Me too test failed, but not timeout error.
I don't know why occurred this errors...

container-tests

A lot of following errors.

D0317 14:14:10.953592      25 container.go:989] Starting gofer: /tmp/use-error-wrapping/runsc [runsc-gofer --root=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/3596/execroot/__main__/_tmp/610a281328b4be58d07ead1cbd77ef2b/containers3572142354 --debug=true --debug-log=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/3596/execroot/__main__/bazel-out/k8-fastbuild/testlogs/runsc/container/container_test/shard_3_of_4/test.outputs/runsc.log.TestMultiContainerSharedMountRestart.%TIMESTAMP%.%COMMAND% --network=none --log-packets=true --platform=kvm --strace=true --watchdog-action=panic --vfs2=false --TESTONLY-unsafe-nonroot=true --debug-log-fd=3 gofer --bundle /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/3596/execroot/__main__/_tmp/610a281328b4be58d07ead1cbd77ef2b/bundle1403834794 --spec-fd=4 --mounts-fd=5 --io-fds=6 --io-fds=7]
D0317 14:14:10.977137      25 container.go:729] Destroy container, cid: test-container-KRBNGSQ7UCEVRSOVU7CTBNIIJYCG4MNK
--- FAIL: TestMultiContainerSharedMountRestart (0.12s)
    --- FAIL: TestMultiContainerSharedMountRestart/ptrace (0.02s)
        multi_container_test.go:1494: error starting containers: error creating container: gofer: fork/exec /tmp/use-error-wrapping/runsc: no such file or directory
    --- FAIL: TestMultiContainerSharedMountRestart/kvm (0.02s)
        multi_container_test.go:1494: error starting containers: error creating container: gofer: fork/exec /tmp/use-error-wrapping/runsc: no such file or directory
    --- FAIL: TestMultiContainerSharedMountRestart/ptrace-overlay (0.02s)
        multi_container_test.go:1494: error starting containers: error creating container: gofer: fork/exec /tmp/use-error-wrapping/runsc: no such file or directory
    --- FAIL: TestMultiContainerSharedMountRestart/kvm-overlay (0.02s)
        multi_container_test.go:1494: error starting containers: error creating container: gofer: fork/exec /tmp/use-error-wrapping/runsc: no such file or directory
    --- FAIL: TestMultiContainerSharedMountRestart/ptrace-vfs1 (0.02s)
        multi_container_test.go:1494: error starting containers: error creating container: gofer: fork/exec /tmp/use-error-wrapping/runsc: no such file or directory
    --- FAIL: TestMultiContainerSharedMountRestart/kvm-vfs1 (0.02s)
        multi_container_test.go:1494: error starting containers: error creating container: gofer: fork/exec /tmp/use-error-wrapping/runsc: no such file or directory
================================================================================
[3,640 / 3,689] 1 / 3 tests, 1 failed; [Prepa] Analyzing //pkg/sentry/fsimpl/verity:verity ... (2 actions, 0 running)
[3,683 / 3,689] 1 / 3 tests, 1 failed; [Prepa] Analyzing //runsc/boot:boot
INFO: Elapsed time: 216.069s, Critical Path: 200.11s
INFO: 1831 processes: 16 internal, 1487 linux-sandbox, 328 local.
INFO: Build completed, 1 test FAILED, 1831 total actions
//runsc/container:container_nogo                                         PASSED in 0.1s
//runsc/container:container_test_nogo                                    PASSED in 0.1s
//runsc/container:container_test                                         FAILED in 4 out of 4 in 4.0s
  Stats over 4 runs: max = 4.0s, min = 1.9s, avg = 2.5s, dev = 0.8s
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/runsc/container/container_test/shard_2_of_4/test.log
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/runsc/container/container_test/shard_4_of_4/test.log
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/runsc/container/container_test/shard_1_of_4/test.log
  /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/execroot/__main__/bazel-out/k8-fastbuild/testlogs/runsc/container/container_test/shard_3_of_4/test.log

Executed 3 out of 3 tests: 2 tests pass and 1 fails locally.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
INFO: Build completed, 1 test FAILED, 1831 total actions
INFO: Build Event Protocol files produced successfully.
INFO: Build completed, 1 test FAILED, 1831 total actions
Makefile:210: recipe for target 'container-tests' failed
make: *** [container-tests] Error 3

syscall-tests

A lot of following errors.

very long
--- FAIL: AllUnixDomainSockets/UnixSocketPairCmsgTest_CloexecDroppedWhenFDPassed/2 (0.00s)
    main.go:433: test "AllUnixDomainSockets/UnixSocketPairCmsgTest.CloexecDroppedWhenFDPassed/2" failed with error fork/exec /tmp/use-error-wrapping/runsc: no such file or directory, want nil
I0317 14:26:53.933205      14 main.go:164] Running test "AllUnixDomainSockets/UnixSocketPairCmsgTest.CloexecDroppedWhenFDPassed/10" in container "test-container-6QI5DOI76ALKL3UNA6YII57V632VKC2X"
D0317 14:26:53.933318      14 specutils.go:75] Spec:
{
  "ociVersion": "",
  "process": {
    "user": {
      "uid": 0,
      "gid": 0
    },
    "args": [
      "/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/bin/test/syscalls/socket_unix_pair_test_runsc_ptrace.runfiles/__main__/test/syscalls/linux/socket_unix_pair_test",
      "--gtest_filter=AllUnixDomainSockets/UnixSocketPairCmsgTest.CloexecDroppedWhenFDPassed/10"
    ],
    "env": [
      "PARTITION=1",
      "TEST_UNUSED_RUNFILES_LOG_FILE=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/test/syscalls/socket_unix_pair_test_runsc_ptrace/shard_3_of_8/test.unused_runfiles_log",
      "TEST_BINARY=test/syscalls/socket_unix_pair_test_runsc_ptrace",
      "TOTAL_PARTITIONS=1",
      "TEST_WORKSPACE=__main__",
      "RUNFILES_DIR=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/bin/test/syscalls/socket_unix_pair_test_runsc_ptrace.runfiles",
      "TEST_UNDECLARED_OUTPUTS_DIR=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/test/syscalls/socket_unix_pair_test_runsc_ptrace/shard_3_of_8/test.outputs",
      "PWD=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/bin/test/syscalls/socket_unix_pair_test_runsc_ptrace.runfiles/__main__",
      "RUN_UNDER_RUNFILES=1",
      "TZ=UTC",
      "TMPDIR=/tmp",
      "XML_OUTPUT_FILE=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/test/syscalls/socket_unix_pair_test_runsc_ptrace/shard_3_of_8/test.xml",
      "TEST_UNDECLARED_OUTPUTS_ANNOTATIONS_DIR=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/test/syscalls/socket_unix_pair_test_runsc_ptrace/shard_3_of_8/test.outputs_manifest",
      "TEST_PREMATURE_EXIT_FILE=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/test/syscalls/socket_unix_pair_test_runsc_ptrace/shard_3_of_8/test.exited_prematurely",
      "TEST_INFRASTRUCTURE_FAILURE_FILE=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/test/syscalls/socket_unix_pair_test_runsc_ptrace/shard_3_of_8/test.infrastructure_failure",
      "USER=root",
      "PYTHON_RUNFILES=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/bin/test/syscalls/socket_unix_pair_test_runsc_ptrace.runfiles",
      "TEST_SRCDIR=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/bin/test/syscalls/socket_unix_pair_test_runsc_ptrace.runfiles",
      "SHLVL=0",
      "RUNTIME=/tmp/use-error-wrapping/runsc",
      "PATH=.:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
      "GTEST_TMP_DIR=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/_tmp/adc88d6afba3fa02fe5e7986f8f58c15",
      "TEST_WARNINGS_OUTPUT_FILE=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/test/syscalls/socket_unix_pair_test_runsc_ptrace/shard_3_of_8/test.warnings",
      "TEST_TARGET=//test/syscalls:socket_unix_pair_test_runsc_ptrace",
      "JAVA_RUNFILES=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/bin/test/syscalls/socket_unix_pair_test_runsc_ptrace.runfiles",
      "TEST_SIZE=large",
      "EXPERIMENTAL_SPLIT_XML_GENERATION=1",
      "TEST_TIMEOUT=900",
      "TEST_SHARD_STATUS_FILE=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/test/syscalls/socket_unix_pair_test_runsc_ptrace/shard_3_of_8/test.shard",
      "TEST_LOGSPLITTER_OUTPUT_FILE=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/test/syscalls/socket_unix_pair_test_runsc_ptrace/shard_3_of_8/test.raw_splitlogs/test.splitlogs",
      "OLDPWD=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__",
      "BASH_FUNC_rlocation%%=() {  if is_absolute \"$1\"; then\n echo \"$1\";\n else\n if [[ -e \"$TEST_SRCDIR/$1\" ]]; then\n echo \"$TEST_SRCDIR/$1\";\n else\n if [[ -e \"$RUNFILES_MANIFEST_FILE\" ]]; then\n echo \"$(grep \"^$1 \" \"$RUNFILES_MANIFEST_FILE\" | sed 's/[^ ]* //')\";\n fi;\n fi;\n fi\n}",
      "BASH_FUNC_is_absolute%%=() {  [[ \"$1\" = /* ]] || [[ \"$1\" =~ ^[a-zA-Z]:[/\\\\].* ]]\n}",
      "TEST_ON_GVISOR=ptrace",
      "GVISOR_NETWORK=none",
      "FUSE_ENABLED=FALSE",
      "LISAFS_ENABLED=FALSE",
      "TEST_TMPDIR=/root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/_tmp/adc88d6afba3fa02fe5e7986f8f58c15/3012181477"
    ],
    "cwd": ""
  },
  "root": {
    "path": "/"
  },
  "hostname": "runsc-test-hostname"
}
I0317 14:26:53.933413      14 main.go:213] runsc logs: /root/.cache/bazel/_bazel_root/c72a1d54bb3652b1e51b83ebaffd2eca/sandbox/linux-sandbox/5339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/test/syscalls/socket_unix_pair_test_runsc_ptrace/shard_3_of_8/test.outputs/AllUnixDomainSockets_UnixSocketPairCmsgTest.CloexecDroppedWhenFDPassed_10/runsc3188279709/
Executed 1234 out of 1234 tests: 161 tests pass and 1073 fail locally.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
INFO: Build completed, 1073 tests FAILED, 7973 total actions
INFO: Build Event Protocol files produced successfully.
INFO: Build completed, 1073 tests FAILED, 7973 total actions
Makefile:227: recipe for target 'syscall-tests' failed
make: *** [syscall-tests] Error 3

@ryo-yamaoka
Copy link

For now, your PR's CI failed by simple issue.
The code you fixed is looks no problem.
I think that CI will pass by fix this, so I think it is a good idea to try that first.
#7285 (comment)

@Yuya9786
Copy link

@ryo-yamaoka Thank you for your help.
I haven't yet figured out the cause of this error too.

copybara-service bot pushed a commit that referenced this issue Mar 17, 2022
Issue #2270

I changed `fmt.Errorf`s' `%v` to `%w` and succeeded to build,
but I couldn't succeed to test because of timeout.
My laptop specs might be not good enough.
In Issue #6797, one person said 8-core-setup could pass most of tests (#6797 (comment)),
but I can't afford of it.
So could someone test this?

FUTURE_COPYBARA_INTEGRATE_REVIEW=#7285 from Yuya9786:use-error-wrapping 03a4c5a
PiperOrigin-RevId: 435254497
@ianlewis ianlewis linked a pull request Apr 3, 2022 that will close this issue
@ianlewis ianlewis removed their assignment Nov 16, 2022
@noopta
Copy link

noopta commented Apr 11, 2023

Is this issue still active? I'd like to try taking on this as my first issue

@milantracy
Copy link
Contributor

it seems that @Yuya9786 had a PR which was ready to be merged, while there are some conflicts with the master branch.

You may confirm with the author to see if it will be updated.

@Yuya9786
Copy link

I think my PR was approved by two reviewers and I resolved the conflicts once, but it's not been merged.
So honestly I don't know what to do

@milantracy
Copy link
Contributor

hey @Yuya9786 thanks for the pr, it seems that there are still some conflicts that block the merge, e.g. VFS1 was completed removed at pkg/sentry/fs which your change are also applied to.

Could you rebase your change and resolve those conflicts? Then we shall be able to merge the pull request.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 120 days.

@github-actions github-actions bot added stale-issue This issue has not been updated in 120 days. and removed stale-issue This issue has not been updated in 120 days. labels Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority: p3 Low priority status: help wanted Extra attention is needed type: cleanup Refactorings and cleanups to improve the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants