-
Notifications
You must be signed in to change notification settings - Fork 2.3k
txtar: add CRLF handling #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: b70202e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
This PR (HEAD: c50c34e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: f9b524e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it. Tip: You can toggle comments from me using the |
Message from Ian Lance Taylor: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
This PR (HEAD: 88f0cf9) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it. Tip: You can toggle comments from me using the |
Message from Bryan Mills: Patch Set 7: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
This PR (HEAD: 74045de) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 22283d2) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 87bb02e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 8d10046) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it. Tip: You can toggle comments from me using the |
Message from Jakub Skiba: Patch Set 11: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
Message from Jakub Skiba: Patch Set 11: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
Message from [email protected]: Patch Set 11: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
Message from Subham Sarkar: Patch Set 11: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
This PR (HEAD: bfc2156) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it. Tip: You can toggle comments from me using the |
Message from [email protected]: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
Message from Jakub Skiba: Patch Set 11: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
Message from Jakub Skiba: Patch Set 12: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
Message from Bryan Mills: Patch Set 12: (9 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
This PR (HEAD: bfc2156) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/483335. Important tips:
|
This PR (HEAD: 5b9bb80) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/483335. Important tips:
|
Message from Jakub Skiba: Patch Set 14: (9 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
Message from Ian Lance Taylor: Patch Set 15: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
This PR (HEAD: 125ba20) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/483335. Important tips:
|
Message from Jakub Skiba: Patch Set 15: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
This PR (HEAD: e98c184) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/483335. Important tips:
|
Message from Ian Lance Taylor: Patch Set 17: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
Message from Gopher Robot: Patch Set 17: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
Message from Gopher Robot: Patch Set 17: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
Message from Bryan Mills: Patch Set 17: Code-Review+1 (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. |
Format
will use the same line separator as the one used in the comment or (if the line separator is not found in the comment) in the filesParse
will use the same line separator as the one found before the first occurrence of a file markerFixes golang/go#59264