Skip to content

reflect: clarify documentation for Value.Seq/Seq2 #67268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/reflect/iter.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ package reflect

import "iter"

// Seq returns an iter.Seq[reflect.Value] that loops over the elements of v.
// Seq returns an iter.Seq[Value] that loops over the elements of v.
// If v's kind is Func, it must be a function that has no results and
// that takes a single argument of type func(T) bool for some type T.
// If v's kind is Pointer, the pointer element type must have kind Array.
Expand Down Expand Up @@ -87,7 +87,11 @@ func (v Value) Seq() iter.Seq[Value] {
panic("reflect: " + v.Type().String() + " cannot produce iter.Seq[Value]")
}

// Seq2 is like Seq but for two values.
// Seq2 returns an iter.Seq2[Value, Value] that loops over the elements of v.
// If v's kind is Func, it must be a function that has no results and
// that takes a single argument of type func(K, V) bool for some type K, V.
// If v's kind is Pointer, the pointer element type must have kind Array.
// Otherwise v's kind must be Array, Map, Slice, or String.
func (v Value) Seq2() iter.Seq2[Value, Value] {
if canRangeFunc2(v.typ()) {
return func(yield func(Value, Value) bool) {
Expand Down