net/http: fix request canceler leak on connection close #62305

AlexanderYastrebov · 2023-08-26T23:47:51Z

writeLoop goroutine closes persistConn closech in case of request body
write error which in turn finishes readLoop without removing request canceler.

Fixes #61708

gopherbot · 2023-08-26T23:51:15Z

This PR (HEAD: 9389b06) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/523296.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-08-26T23:56:46Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-27T00:07:46Z

Message from Alexander Yastrebov:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-28T16:27:30Z

Message from Damien Neil:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-28T16:33:50Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-28T16:40:10Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-28T16:40:11Z

Message from Gopher Robot:

Patch Set 2: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-28T16:40:12Z

Message from Damien Neil:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-28T19:01:33Z

This PR (HEAD: 4969358) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/523296.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-08-28T19:07:34Z

Message from Alexander Yastrebov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-28T23:50:25Z

This PR (HEAD: dcbcf7a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/523296.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-08-29T00:27:54Z

Message from Alexander Yastrebov:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-23T16:15:19Z

Message from Alexander Yastrebov:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-06T21:56:49Z

Message from Damien Neil:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-06T21:56:50Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-06T21:44:43Z","revision":"3a74d0a3b6093c4978adce208273cc78eef81469"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-06T21:56:51Z

Message from Damien Neil:

Patch Set 4: Auto-Submit+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-06T22:04:03Z

Message from Damien Neil:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-06T22:04:04Z

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

FAILURE

go on master (change 523296)
tools on master (commit 2881318)

error: failed to run "test golang.org/x/tools module": exit status 1

"test golang.org/x/tools module" (combined output)

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-06T22:04:05Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T12:05:14Z

This PR (HEAD: a56811e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/523296.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-10T18:02:57Z

Message from Damien Neil:

Patch Set 5: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T18:09:19Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-10T17:52:03Z","revision":"4ac729a7690d8ed3803f816b6302cd987ba276d1"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T18:22:04Z

Message from Damien Neil:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T18:22:04Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T18:22:05Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T21:17:05Z

Message from Heschi Kreinick:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-07T17:42:26Z

Message from Carlos Amedee:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

writeLoop goroutine closes persistConn closech in case of request body write error which in turn finishes readLoop without removing request canceler. Fixes golang#61708

gopherbot · 2024-03-12T15:41:05Z

This PR (HEAD: b74b905) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/523296.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-03-12T16:34:36Z

Message from Alexander Yastrebov:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T16:26:44Z

Message from Damien Neil:

Patch Set 6: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T16:33:06Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-03-18T16:18:37Z","revision":"ead2956affec451a4c19013e89db255b3647b693"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T16:46:10Z

Message from Damien Neil:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T16:46:11Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T16:46:11Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/523296.
After addressing review feedback, remember to publish your drafts!

writeLoop goroutine closes persistConn closech in case of request body write error which in turn finishes readLoop without removing request canceler. Fixes #61708 Change-Id: Ib7c832a91b49bc7888a35a4fd2bd692236c04f86 GitHub-Last-Rev: b74b905 GitHub-Pull-Request: #62305 Reviewed-on: https://go-review.googlesource.com/c/go/+/523296 Reviewed-by: Carlos Amedee <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Damien Neil <[email protected]>

gopherbot · 2024-03-18T19:39:42Z

This PR is being closed because golang.org/cl/523296 has been merged.

AlexanderYastrebov force-pushed the go61708-conn branch from 9389b06 to 4969358 Compare August 28, 2023 18:55

AlexanderYastrebov force-pushed the go61708-conn branch from 4969358 to dcbcf7a Compare August 28, 2023 23:43

AlexanderYastrebov force-pushed the go61708-conn branch from dcbcf7a to a56811e Compare November 10, 2023 12:03

net/http: fix request canceler leak on connection close

b74b905

writeLoop goroutine closes persistConn closech in case of request body write error which in turn finishes readLoop without removing request canceler. Fixes golang#61708

AlexanderYastrebov force-pushed the go61708-conn branch from a56811e to b74b905 Compare March 12, 2024 15:37

gopherbot closed this Mar 18, 2024

net/http: fix request canceler leak on connection close #62305

net/http: fix request canceler leak on connection close #62305

Conversation

AlexanderYastrebov commented Aug 26, 2023 • edited Loading

gopherbot commented Aug 26, 2023

gopherbot commented Aug 26, 2023

gopherbot commented Aug 27, 2023

gopherbot commented Aug 28, 2023

gopherbot commented Aug 28, 2023

gopherbot commented Aug 28, 2023

gopherbot commented Aug 28, 2023

gopherbot commented Aug 28, 2023

gopherbot commented Aug 28, 2023

gopherbot commented Aug 28, 2023

gopherbot commented Aug 28, 2023

gopherbot commented Aug 29, 2023

gopherbot commented Sep 23, 2023

gopherbot commented Nov 6, 2023

gopherbot commented Nov 6, 2023

gopherbot commented Nov 6, 2023

gopherbot commented Nov 6, 2023

gopherbot commented Nov 6, 2023

gopherbot commented Nov 6, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Dec 7, 2023

gopherbot commented Mar 12, 2024

gopherbot commented Mar 12, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

AlexanderYastrebov commented Aug 26, 2023 •

edited

Loading