Skip to content

chore(consumer): remove metrics #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2022
Merged

chore(consumer): remove metrics #51

merged 1 commit into from
Mar 28, 2022

Conversation

appleboy
Copy link
Member

fix #50

Signed-off-by: Bo-Yi Wu [email protected]

@appleboy appleboy added the enhancement New feature or request label Mar 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #51 (2510c2f) into master (fd4ed0b) will increase coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   84.77%   85.15%   +0.37%     
==========================================
  Files          10       10              
  Lines         440      431       -9     
==========================================
- Hits          373      367       -6     
+ Misses         62       59       -3     
  Partials        5        5              
Flag Coverage Δ
go-1.13 84.45% <ø> (-0.32%) ⬇️
go-1.14 84.45% <ø> (-0.32%) ⬇️
go-1.15 84.45% <ø> (-0.32%) ⬇️
go-1.16 84.45% <ø> (-0.32%) ⬇️
go-1.17 85.15% <ø> (+0.37%) ⬆️
go-1.18 84.45% <ø> (-0.32%) ⬇️
ubuntu-latest 85.15% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consumer.go 88.88% <ø> (-1.02%) ⬇️
queue.go 87.57% <0.00%> (+1.12%) ⬆️
worker_empty.go 50.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd4ed0b...2510c2f. Read the comment docs.

@appleboy appleboy merged commit 94512c6 into master Mar 28, 2022
@appleboy appleboy deleted the consumer branch March 28, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Consumer Metrics
2 participants