ClassName now dynamic and faster
#834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only for Gd<T>, where the class name is not available as literal.
Bromeon
added
c: core
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-834 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks
ClassNameto be faster and more versatile.It now supports arbitrary
Stringvalues, not just literals. At the same time,ClassNameis stillCopy. Names of Godot classes or user ones created via#[derive(Godot)]should now resolve their name very quickly, not even hash is needed anymore.Closes #792. At least the direct suspect is related to
ClassName, and I think that should (hopefully) be out of the way now. If there are remaining performance problems in this context, please provide profiling information.