Improve cargo check times for incremental changes to godot-core
#266
Conversation
Incremental rebuild of `cargo check` after change in godot-core timings: before: 48.015s average after: 32.063s average diff: -33.22%
Incremental rebuild of `cargo check` after change in godot-core timings: before: 32.63s average after: 11.068s average diff: -65.48%
lilizoey
added
quality-of-life
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-266 |
|
Good catch! I definitely wouldn't have expected such an impact. bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
|
Today I learned from here that glob imports are resolved differently from named imports. For ergonomics reasons, name collisions when importing multiple globs are ignored until you actually try to use an ambiguous name. So my guess is that these imports are resolved lazily, and the compiler has to work harder to resolve each identifier if there are any glob imports in scope. I can't find any mention on the rustc issue tracker about this though. |
On my machine, this change makes the time
cargo checktakes to run go from 48 seconds to 11 seconds when making an incremental change togodot-core. in this case tested by adding/removing a single method to/fromBasis.I've seen it be as low as 2 seconds sometimes but im not entirely sure why that happens.