Adjust target feature instructions for Wasm threading #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on findings from godot-rust/gdext#1105 and godot-rust/gdext#1107, I propose:
-Ctarget-features=+atomics
when compiling a nothreads build, to ensurestd
is compiled without multi-threading (using polyfills for threading APIs).+mutable-globals
target feature anymore in any wasm builds, as it appears to be stable and enabled by default now, per https://doc.rust-lang.org/1.85.1/rustc/platform-support/wasm32-unknown-unknown.html#enabled-webassembly-features+bulk-memory
target feature as well. In principle, some error messages from emscripten suggest to me that+atomics
is sufficient here, as removing this flag made my rather simple test project (with async signals for fancier testing) work all the same. However, let's keep an eye on this in case someone has a problem with this.