Insert NULL for []byte(nil) values #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM after you add a test... 😏 |
Also reordered the tests so that the general tests are on top
|
PTAL at the new test. I reordered the tests so that the general tests are on top and fail first. Any objections against this change? |
Closed
|
I'd prefer to put (future) reorderings into an extra PR and keep functional and layout changes separate. |
|
PTAL, I found another bug: Empty strings / |
| @@ -632,40 +632,31 @@ func skipLengthEnodedString(b []byte) (int, error) { | |||
| return n, io.EOF | |||
| } | |||
|
|
|||
| func readLengthEncodedInteger(b []byte) (num uint64, isNull bool, n int) { | |||
There was a problem hiding this comment.
Leave these in please. They are a pretty concise documentation of what is returned.
There was a problem hiding this comment.
I still prefer the short form below. We don't have to use the vars, I just like to keep them.
|
LGTM when Travis says so |
julienschmidt
added a commit
that referenced
this pull request
Nov 1, 2013
Insert NULL for []byte(nil) values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes a behavior change for inserting data into a database:
Currently
[]byte(nil)is treated the same way as[]byte{}/[]byte(""), which equals an empty string.This relies on the current language specification: http://golang.org/ref/specThis PR changes to behavior to treat
[]byte(nil)as NULL values, therefore the same way asinterface{}(nil).Here is why:
Both
[]byte(nil)andinterface{}(nil)are converted to[]byte(nil)by the database/sql package if the destination has the type[]byte. This matches the new behavior.Fixes #144