-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Refactored and fixed migration tests #16714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored and fixed migration tests #16714
Conversation
Codecov Report
@@ Coverage Diff @@
## main #16714 +/- ##
==========================================
- Coverage 45.38% 45.37% -0.02%
==========================================
Files 758 758
Lines 85306 85381 +75
==========================================
+ Hits 38713 38738 +25
- Misses 40313 40362 +49
- Partials 6280 6281 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the initial comment to explain that you've fixed some other little bugs too?
I see for example you've set the PosterID in Gogs which was previously missing.
done |
I've refactored and fixed the migration tests. They now use all the same test methods.
The tests for Gitlab, Gitea and Gogs were broken and are fixed now.
I removed the usage of
time.Now()
in the downloaders because you can't write normal tests with changing values. Empty timestamps are now populated in the uploader.Other changes/fixes:
MergeRequestApprovals.GetConfiguration
instead ofMergeRequestApprovals.GetApprovalState