Skip to content

Add GOFLAGS and EXTRA_GOFLAGS #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2017
Merged

Add GOFLAGS and EXTRA_GOFLAGS #1438

merged 1 commit into from
Apr 5, 2017

Conversation

typeless
Copy link
Contributor

@typeless typeless commented Apr 4, 2017 •
edited
Loading

With these flags (modelling after CFLAGS and EXTRA_CFLAGS), we can enable race detector by setting environment variables.

E.g. EXTRA_GOFLAGS=-race make or make EXTRA_GOFLAGS=-race

For #1430

@lunny lunny added this to the 1.2.0 milestone Apr 4, 2017
@lunny lunny added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Apr 4, 2017
@typeless typeless mentioned this pull request Apr 4, 2017
Merged
@strk
Copy link
Member

strk commented Apr 4, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 4, 2017
@appleboy
Copy link
Member

appleboy commented Apr 5, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 5, 2017
@appleboy appleboy merged commit 2d1efcc into go-gitea:master Apr 5, 2017
@typeless typeless deleted the race-detector-enabler branch April 3, 2019 05:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@typeless @strk @appleboy @lunny @tboerger