Make TaskCheckBox render correctly

[zeripath]

• Add correct styling to TaskCheckBoxes.
• Restore the correct check order

Fix #11213

Signed-off-by: Andrew Thornton [email protected]

[zeripath]

For some unknown reason prior to 812cfd0 isChecked meant that the checkbox should be rendered not checked but after this commit it has returned to the correct sense. I have been unable to find any clear reason why this happened - presumably the change in the priority of the renderer here:

https://github.com/go-gitea/gitea/blob/774ce39d3f35286b2c22d37d5f4b585eeff6df7b/modules/markup/markdown/markdown.go#L74

from:

gitea/modules/markup/markdown/markdown.go

Line 74 in 0be25e2

util.Prioritized(NewTaskCheckBoxHTMLRenderer(), 1000),

means that there was a renderer running before ours that is munging the AST in some way.

[CirnoT]

It would seem that tasklist renderer took over and renderTaskCheckBox was never executed in the first place.

[zeripath]

As discussed on discord previously these checkboxes were rendered incorrectly - I have now restored the correct fomantic styling.

[CirnoT]

Works fine here, but I have one small nitpick about how it looks on light style:

I am wondering if it wouldn't be better to apply read-only instead of disabled:

While I realize that disabled does a better job for cases like above, where it's a single checkbox, on a long lists of to-do items it might look a little weird.

[CirnoT]

^ Here's example with a rather long list, notice how links can't be clicked on when disabled is present:

[zeripath]

Thanks for checking that I had totally missed that problem!

[zeripath]

Setting them to readonly instead appears to fix the problem.

[codecov-io]

Codecov Report

Merging #11214 into master will decrease coverage by 0.02%.
The diff coverage is 10.44%.

@@            Coverage Diff             @@
##           master   #11214      +/-   ##
==========================================
- Coverage   43.22%   43.20%   -0.03%     
==========================================
  Files         604      604              
  Lines       86004    86050      +46     
==========================================
+ Hits        37175    37177       +2     
- Misses      44237    44283      +46     
+ Partials     4592     4590       -2     

Impacted Files	Coverage Δ
modules/markup/markdown/ast.go	0.00% <0.00%> (ø)
modules/markup/markdown/goldmark.go	36.96% <2.08%> (-4.71%)	⬇️
modules/markup/sanitizer.go	93.10% <100.00%> (+0.33%)	⬆️
modules/charset/charset.go	69.56% <0.00%> (-3.27%)	⬇️
services/pull/check.go	52.43% <0.00%> (-3.05%)	⬇️
modules/git/command.go	86.95% <0.00%> (-2.61%)	⬇️
services/gitdiff/gitdiff.go	72.57% <0.00%> (-1.86%)	⬇️
modules/queue/workerpool.go	56.93% <0.00%> (-1.07%)	⬇️
models/issue.go	51.86% <0.00%> (+0.46%)	⬆️
modules/notification/webhook/webhook.go	40.20% <0.00%> (+0.58%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f56da...fa3567c. Read the comment docs.