-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Template Rendering Error When Viewing Pull-Requests #18706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This appears to happen only if the PR refers to a broken Git state. In our case, this happened by creating a PR via the API. |
Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo. Fix go-gitea#18706 Signed-off-by: Andrew Thornton <[email protected]>
…18713) Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo. Fix #18706 Signed-off-by: Andrew Thornton <[email protected]>
Wait for backport |
…o-gitea#18713) Backport go-gitea#18713 Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo. Fix go-gitea#18706 Signed-off-by: Andrew Thornton <[email protected]>
…18713) (#18737) Backport #18713 Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo. Fix #18706 Signed-off-by: Andrew Thornton <[email protected]>
Is there a workaround for this issue? After the weekend all of our Pull-Requests suddenly show this error. All Pull-Request were created through the web-interface. |
If you are affected by this bug, you can try to download the latest 1.16-dev from https://dl.gitea.io/gitea/1.16/ , it includes this fix. If the releases in https://dl.gitea.io/gitea/1.16/ doesn't help, then the bug you meet could be a new one. |
Thanks for the quick reply, I tried the dev-build and it indeed fixes the 500 HTTP-Error. |
…o-gitea#18713) Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo. Fix go-gitea#18706 Signed-off-by: Andrew Thornton <[email protected]>
Gitea Version
1.16.1
Git Version
No response
Operating System
Linux Debian 11
How are you running Gitea?
We're using the Gitea binary
gitea-1.16.1-linux-amd64
from the "Releases" page.An Nginx reverse proxy communicates with Gitea via
http+unix
(HTTP over Unix sockets).Database
No response
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
https://gist.github.com/rtpt-jonaslieb/23ad0a6d873ade04aac7e2ad55f0dfd2
Description
Gitea displays a 500 server error upon viewing an unmerged pull request. The corresponding log is attached to this issue.
It does not happen with pull requests that have been merged or closed.
The underlying issue appears to be that
PullRequestWorkInProgressPrefixes
is undefined insidebar.tmpl
.The corresponding render-call is here:
gitea/routers/web/repo/issue.go
Line 1657 in bb77e6c
in function
ViewIssue
:gitea/routers/web/repo/issue.go
Line 1083 in bb77e6c
The error occurs even if
WORK_IN_PROGRESS_PREFIXES = WIP:,[WIP]
is explicitly included in theapp.ini
sectionrepository.pull-request
.I'm not quite sure why the issue cannot be reproduced on the Gitea demo instance.
Screenshots
No response
The text was updated successfully, but these errors were encountered: