Skip to content

Postprocess performance profile #16092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lunny opened this issue Jun 6, 2021 · 1 comment · Fixed by #16101
Closed

Postprocess performance profile #16092

lunny opened this issue Jun 6, 2021 · 1 comment · Fixed by #16101
Labels
performance/speed performance issues with slow downs

Comments

@lunny
Copy link
Member

lunny commented Jun 6, 2021 •
edited
Loading

Postprocess is very slow when render a 900 line csv file. This is the cpu profile graph.

图片
@zeripath
Copy link
Contributor

zeripath commented Jun 6, 2021

yup the sha1ccommand processer thing is kinda silly - should be able to pass these to the batch-check

@lunny lunny added the performance/speed performance issues with slow downs label Jun 7, 2021
@zeripath zeripath mentioned this issue Jun 7, 2021
Merged
zeripath added a commit to zeripath/gitea that referenced this issue Jun 7, 2021
@zeripath
More efficiently parse shas for shaPostProcessor
662cbc1 
The shaPostProcessor currently repeatedly calls git rev-parse --verify on both backends
which is fine if there is only one thing that matches a sha - however if there are
multiple things then this becomes wildly inefficient.

This PR provides functions for both backends which are much faster to use.

Fix go-gitea#16092

Signed-off-by: Andrew Thornton <[email protected]>
6543 added a commit that referenced this issue Jun 20, 2021
@zeripath @6543
More efficiently parse shas for shaPostProcessor (#16101)
196593e 
* More efficiently parse shas for shaPostProcessor

The shaPostProcessor currently repeatedly calls git rev-parse --verify on both backends
which is fine if there is only one thing that matches a sha - however if there are
multiple things then this becomes wildly inefficient.

This PR provides functions for both backends which are much faster to use.

Fix #16092

* Add ShaExistCache to RenderContext

Signed-off-by: Andrew Thornton <[email protected]>
Co-authored-by: 6543 <[email protected]>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 10, 2021
@zeripath @6543 @AbdulrhmnGhanem
More efficiently parse shas for shaPostProcessor (go-gitea#16101)
871f1c0 
* More efficiently parse shas for shaPostProcessor

The shaPostProcessor currently repeatedly calls git rev-parse --verify on both backends
which is fine if there is only one thing that matches a sha - however if there are
multiple things then this becomes wildly inefficient.

This PR provides functions for both backends which are much faster to use.

Fix go-gitea#16092

* Add ShaExistCache to RenderContext

Signed-off-by: Andrew Thornton <[email protected]>
Co-authored-by: 6543 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
performance/speed performance issues with slow downs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More efficiently parse shas for shaPostProcessor zeripath/gitea
2 participants
@lunny @zeripath