feature offline mode. #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes: go-flutter-desktop/go-flutter#169 - provide a `hover upgrade `command (like flutter upgrade) - every 2 days a check is made to see if the current project tags uses the last github release. if a new release is available print a message about `hover upgrade` - adds more debug message, 'bundling flutter', 'compiling go-flutter', 'running project',... - only print the 'channel beta' message if the user is on master, if the user was on stable the message was printed for no reason. The behaviour of `hover run` and `hover build` is the same as before when `--branch` is provided. But there is a little twist, if the current version is a valid release (available on github), `hover run` will not overwrite the 'go-flutter' version. Example: ``` $ hover run --branch '@v0.20.0' $ hover run # no upgrade trigged running on v0.20.0, at some point you # will get a `hover upgrade` notice $ hover upgrade # user has to run to upgrade away from v0.20.0 $ $ hover run --branch '@master' $ hover run # auto upgrade trigged! Not a real release. # If the user hasn't access to internet, fail silently and # keep using '@master' ``` To check every two days, a hidden file `./desktop/.last_goflutter_check` is created on a project bases, the file contains a timestamps indicating the last hover update check. About the hover repo: A empty go.mod file has been added to hover/assets/app/ this prevent adding `go-flutter` as a go mod dependency. (because `go mod tidy` was peeking listing hover/asset/options.go as a hover code file)
pchampio
force-pushed
the
feature/speed-up-builds
branch
from
8bc9611 to
5c004e8
Compare
pchampio
force-pushed
the
feature/speed-up-builds
branch
from
31247ff to
fa0878b
Compare
When using hover only for building plugin the `flutter build bundle` slows down the process. Add a flag to omit `flutter build bundle`. When making changes to the flutter package only, omit `go build 'go-flutter'` with the flag omit-embedder.
|
add to |
This was referenced Aug 23, 2019
GeertJohan
reviewed
Aug 27, 2019
GeertJohan
reviewed
Aug 27, 2019
|
Some comments, but overall looks good. |
* chore: add last_goflutter_check into gitignore * ecosystem consideration: prefixing files with 'go-' * add --path flag to all commands * chore: fix indent * Update init.go * address the PR comments
pchampio
force-pushed
the
feature/speed-up-builds
branch
5 times, most recently
from
7a82fb8 to
42e96e2
Compare
pchampio
force-pushed
the
feature/speed-up-builds
branch
from
42e96e2 to
3193bae
Compare
GeertJohan
requested changes
Aug 27, 2019
GeertJohan
reviewed
Aug 27, 2019
GeertJohan
reviewed
Aug 27, 2019
pchampio
force-pushed
the
feature/speed-up-builds
branch
from
1323cec to
fca3a9c
Compare
3 tasks
adds the '.last_goflutter_check' entry to the go/.gitignore file if needed
|
PTAL |
GeertJohan
requested changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hover upgradecommand (to upgrade the current project )github release. if a new release is available print a message about
hover upgradego-flutter', 'running project',...
if the user was on stable the message was printed for no reason.
The behaviour of
hover runandhover buildis the same as beforewhen
--branchis provided.But there is a little twist, if the current version is a valid release
(available on github),
hover runwill not overwrite the 'go-flutter'version. Example:
To check every two days, a hidden file
./desktop/.last_goflutter_checkis created on a project bases, the file contains a timestamps indicating
the last hover update check.
About the hover repo:
A empty go.mod file has been added to hover/assets/app/ this prevent adding
go-flutteras a go mod dependency. (becausego mod tidywas peekinghover/asset/options.go as a hover code file)
fixes: go-flutter-desktop/go-flutter#239