-
Notifications
You must be signed in to change notification settings - Fork 282
rework package to be importable (proof of concept) #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework package to be importable (proof of concept) #4
Conversation
GJ, I like It. From what I see, to be able to build or run we have to specify the // #cgo linux LDFLAGS: -L${SRCDIR}/flutter/library/linux
import "C" About the name since this implementation is bound to glfw. Could we name the library |
not a huge fan of the CGO_LDFLAGS either, I thought about the cgo option as well, though I havent had a chance to test it. might work, still find either solution less than satisfactory as it put requirements on the working directory. either way, both cases are up to the end user to choose to use, so if it your way works no problem putting it in the example. as for the name: we should avoid -'s in the name past experience has should those to be problematic/non-obvious when attempting to actually use the package. |
|
||
import ( | ||
// prevents dep from stripping out the c source files in flutter library. | ||
_ "github.com/Drakirus/go-flutter-desktop-embedder/flutter/library" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just learned something new.
Very useful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useful in this case being a nasty hack because dep does the wrong thing lol
I will merge it soon. |
rework package to be importable (proof of concept) Former-commit-id: 352ada5
go-flutter-desktop-embedder
but requires that the user of the library provide the load path for the flutter engine.
after this changes I was able to get my flutter project to load and display. wasn't entirely functional but was a decent POC.
fixes #3