fixes: #345 InvokeMethodWithReply segfault #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback function used to retrieve the value of the reply was free-ed by the Golang GC. This was quite hard to fix, had to uses runtime.KeepAlive on a struct that contains the callback function. runtime.KeepAlive, ensures that the object is not freed, and its finalizer is not run, before the point in the program where KeepAlive is called. Since the returned value is obtained with the callback function, I used the `defer` keyword to make the function as not used for the gc once we have the reply value.
|
The only thing I would add is that the "trick the panic" comment is not really relevant as the bug is fixed. It would be good to add that explanation in the issue for posterity, but not in the code. |
|
The "trick the panic" message wasn't for this specific issue. I agree, this isn't pretty in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback function used to retrieve the value of the reply was
free-ed by the Golang GC.
This was quite hard to fix, had to uses runtime.KeepAlive on a struct
that contains the callback function.
runtime.KeepAlive, ensures that the object is not freed, and its
finalizer is not run, before the point in the program where KeepAlive is
called. Since the returned value is obtained with the callback function,
I used the
deferkeyword to make the function as not used for the gconce we have the reply value.