Avoid unnecessary PlatformMessage copies in plugin callback loop #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked
PlatformMessage
propagation to use pointers.All golang values are passed by value. That means that when you pass a struct to a function, that's about as efficient as passing all of the struct members as parameters, including copying all the
nested strings.
This might be okay, or even beneficial from GC perspective for small structs such as
PointerEvent
, but is a really bad idea when used in loops (such as callback loop made by the plugin system).The only reason you don't see much of pointers in golang stdlib is, it primarily operates on interfaces, while the interfaces themselves are mostly implemented on pointer, not value types.
Also reworked access to
PlatformMessage.Message
into pointers, for the same reason. No need to change the member itself into pointer -- it's only meaningful to pass with the correspondingPlatformMessage
.