Plugin Support #20
Merged
Plugin Support #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 13, 2018 23:17
Former-commit-id: 1669fb76e1f394c7fdcac9c9772342080b75f422
Changes have been made to the Engine's callback system. Rather than storing in the "C" glfw.Window a user pointer to the "Golang" `flutter.EngineOpenGL`, the "C" user pointer is now storing an `int`. This improves the code segmentation, and remove the famous > panic: runtime error: cgo argument has Go pointer to Go pointer The user pointer `int` is then later used to associate the C callback to the correct flutter.EngineOpenGL. The Embedder can open one Flutter app at the time, work needs to be done to allow 'multiplexing' The user can register a Plugin using the `gutter.OptionAddPluginReceiver` function, I have not look too much at `MessageChannel`, `MethodChannel`, Codec stuff. **The whole method channel/plugin API doesn't match the existing Flutter API** For now, only `string` messages can be sent/received by the plugin system, please use the `JSONMethodCodec` on the Dart side.
Closed
|
The simpleDemo example has been updated! |
This was referenced Sep 8, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes have been made to the Engine's callback system.
Rather than storing in the "C" glfw.Window a user pointer to the "Golang"
flutter.EngineOpenGL, the "C" user pointer is now storing anint.This improves the code segmentation, and remove the famous
The user pointer
intis then later used to associate the C callback to the correct flutter.EngineOpenGL. The Embedder can open one Flutter app at the time, work needs to be done to allow 'multiplexing'The user can register a Plugin using the
gutter.OptionAddPluginReceiverfunction, I have not look too much atMessageChannel,MethodChannel, Codec stuff.The whole method channel/plugin API doesn't match the existing Flutter API
For now, only
stringmessages can be sent/received by the plugin system, please use theJSONMethodCodecon the Dart side.