Skip to content

Adds Support For Multiple Projects #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Adds Support For Multiple Projects #14

wants to merge 8 commits into from

Conversation

TotallyGamerJet
Copy link
Contributor

@TotallyGamerJet TotallyGamerJet commented Sep 21, 2018

Allows the user to execute the program with the flag "-fp=FILENAME" to choose which project they want to run in the embedder. The project must be found in the "flutter_project" folder. If no project is supplied it will default to "stocks". Also, I'm not sure if you want to keep the demo version of the program bc you can just have multiple flutter projects in the same "flutter_project" folder. Just food for thought! :)

Drakirus and others added 5 commits September 13, 2018 23:17
Former-commit-id: 1669fb76e1f394c7fdcac9c9772342080b75f422
Fix: gets the directory of the running file instead of the binaries' temp folder as discussed in this:
 https://stackoverflow.com/questions/18537257/how-to-get-the-directory-of-the-currently-running-file
added path back
Now using the -fp=FILENAME flag you can choose which project you want to run in the "flutter_project" folder. NOTE: If none is supplied it defaults to stocks.
@pchampio
Copy link
Member

pchampio commented Sep 22, 2018

Having a single prebuild embedder is the way to go.
But the commands lines arguments can be defined a bit later, for now this project don't need cl args.
I thinks a config file like a .yaml file would also fit the needs.

#10 Runtime plugins, also have to be prototyped.

@pchampio pchampio added the enhancement New feature or request label Sep 22, 2018
@TotallyGamerJet
Copy link
Contributor Author

I thought it would be a simple (and temporary) way to switch between different projects even after you build it. Obviously, if u want to do yaml that cool too. I just think flags would be a current solution so even less experienced people can download the binary and be able to switch projs.

@pchampio
Copy link
Member

The Flutter application which is loaded into the embedder must have been created with flutter bundle build. The flutter --version must match the version of the engine in use.

This adds a fair amount of complexity.

As a temporary and straightforward way of switching between different projects, I would rather let the user rename their project 'stocks', so that they know it's a hacky solution.

@pchampio pchampio closed this Sep 23, 2018
@winner484 winner484 mentioned this pull request Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants