Skip to content

Support for borderless windows #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atresnjo opened this issue May 17, 2019 · 4 comments · Fixed by #144
Closed

Support for borderless windows #137

atresnjo opened this issue May 17, 2019 · 4 comments · Fixed by #144
Assignees
Labels
plugin Issue about an existing or possible plugin

Comments

@atresnjo
Copy link

Would it be possible to add support for borderless window mode? Thanks! 👍

pchampio pushed a commit that referenced this issue May 17, 2019
Plugin interface doesn't need a glfw.Window to be instantiated.
Calling the init function of the Plugin interface improves the
flexibility. #137
pchampio pushed a commit that referenced this issue May 17, 2019
Plugin interface doesn't need a glfw.Window to be instantiated.
Calling the init function of the Plugin interface improves the
flexibility. #137
@pchampio pchampio self-assigned this May 17, 2019
@pchampio pchampio added the plugin Issue about an existing or possible plugin label May 17, 2019
@GeertJohan
Copy link
Member

This can be done by adding an Option that overrides a default in Application config. By default we should enable borders. They may be disabled in GLFW using the decorated attribute: https://www.glfw.org/docs/latest/window_guide.html#GLFW_DECORATED_attrib

This can be done in core go-flutter. Not sure if it should be a plugin.

@pchampio
Copy link
Member

pchampio commented May 18, 2019

I'll open a PR on go-gl/glfw to support glfwSetWindowAttrib.

Such features can be done in core go-flutter, but I'll like to keep the numbers of Option small. And IMO encouraging people to understand and tweak around the package is better than solving local demands.

@pchampio
Copy link
Member

pchampio commented May 18, 2019

That being said, I think there is room in plug-ins for a specific go-flutter plug-in that will take care of setting an multiple WindowAttrib

@GeertJohan
Copy link
Member

GeertJohan commented May 18, 2019

I think go-flutter must be in charge of the window and application lifecycle. Plugins are meant to support platform specific features that are not in scope for go-flutter. E.g. webcam, audio, webview, etc.
Imo the PluginGLFW interface already exposes too much. I want to write an abstraction layer that is implemented by GLFW (and in the future possibly others). All window settings should be configurable in Application config via Options, so that the user doesnt have to worry about the GL and window managing back-end. Until then the Options can stil be created but applied using the internal plugins workarround, that way they are future compatible, even when PluginGLFW goes away. The option will still be there but work through the correct abstraction layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin Issue about an existing or possible plugin
3 participants