Skip to content

[server, dashboard] Map USER_DELETED properly through the API #20796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

geropl
Copy link
Member

@geropl geropl commented May 6, 2025

Description

The fundamental issue here is that the flow for the deleted user was broken, if they did not delete themselves.

This PR makes sure that:

  • the error ("userDeleted") is properly propagated to the dashboard (and always emits the right error)
  • the UX ensures to a) cleanup the now outdated JWT cookie and b) redirects the user to /login again

I had to touch more code than expected due to general code rot, and some unexpected changes I stumbled over.

Related Issue(s)

Fixes CLC-1327

How to test

Dedicated ✔️

Gitpod.io

validate that session refresh is still working

  • check browser (network tab) AND/OR server logs

Org-owned user (member) ✔️

Primary user ✔️

Primary user (deleted by other person) ✔️

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl
Copy link
Member Author

geropl commented May 7, 2025

/unhold

@roboquat roboquat merged commit 6a6052f into main May 7, 2025
91 of 92 checks passed
@roboquat roboquat deleted the gpl/1327-deleted-user branch May 7, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants