Skip to content

feat: make the volume of notifications adjustable #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 23, 2025
Merged

feat: make the volume of notifications adjustable #1967

merged 11 commits into from
Apr 23, 2025

Conversation

RuizhePang
Copy link
Contributor

@RuizhePang RuizhePang commented Apr 22, 2025 •
edited by setchy
Loading

Closes #1929

Add a spinner in setting page, which can control the volume of notifications.

Play Sound enabled Play Sound disabled
2025-04-23T15-35-26 277Z-Gitify-screenshot 2025-04-22T17-02-43 862Z-Gitify-screenshot

@github-actions github-actions bot added the enhancement New feature or enhancement to existing functionality label Apr 22, 2025
setchy
setchy reviewed Apr 22, 2025
View reviewed changes
setchy
setchy reviewed Apr 22, 2025
View reviewed changes
setchy
setchy reviewed Apr 22, 2025
View reviewed changes
setchy
setchy reviewed Apr 22, 2025
View reviewed changes
setchy
setchy reviewed Apr 22, 2025
View reviewed changes
@setchy setchy added this to the Release 6.3.0 milestone Apr 22, 2025
@setchy
update snapshots
8d5e5c9 
Signed-off-by: Adam Setch <[email protected]>
@setchy
Copy link
Member

setchy commented Apr 22, 2025 •
edited
Loading

A proposed further consolidation of the UI
2025-04-22T19-00-16 845Z-Gitify-screenshot

LMK what you think @RuizhePang @afonsojramos - can push the changes if we think this is a better representation

@RuizhePang
Copy link
Contributor Author

The new version looks great! But the volume down icon looks more like a mute symbol. Is there a more suitable option?

@setchy
Copy link
Member

setchy commented Apr 23, 2025 •
edited
Loading

But the volume down icon looks more like a mute symbol. Is there a more suitable option?

Agree - there isn't a great native option within https://primer.style/octicons/ for Volume Down, however I have used https://primer.style/octicons/icon/unmute-24/ as a base to create a custom Icon

Updated UI
2025-04-23T15-35-26 277Z-Gitify-screenshot

@setchy
update volume icons
2d38735 
Signed-off-by: Adam Setch <[email protected]>
@RuizhePang
Copy link
Contributor Author

But the volume down icon looks more like a mute symbol. Is there a more suitable option?

Agree - there isn't a great native option within https://primer.style/octicons/ for Volume Down, however I have used https://primer.style/octicons/icon/unmute-24/ as a base to create a custom Icon

Updated UI 2025-04-23T15-35-26 277Z-Gitify-screenshot

Excellent! 👍

@setchy setchy merged commit 17d9c58 into gitify-app:main Apr 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setchy setchy setchy approved these changes

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Milestone
Release 6.3.0
Development

Successfully merging this pull request may close these issues.

Support alternative or custom notification sounds
2 participants
@RuizhePang @setchy