Ruby: Order synthetic children in PrintAST based on their index instead of location #12612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
ruby/print-ast-desugar-reorder
branch
3 times, most recently
from
f95e9c9 to
1352d21
Compare
hvitved
force-pushed
the
ruby/print-ast-desugar-reorder
branch
from
1352d21 to
f8c28be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the order in which children of synthesized nodes are being rendered in Print AST, from using the location to using the index into their parent (i.e., evaluation order). Since blocks were previously using index
-2, I had to change that to have blocks be printed after ordinary arguments.I also spotted an off-by-one error, which has been fixed here as well.