Skip to content

Regression from 0.2.0, symbol can't be demangled #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexcrichton opened this issue Mar 27, 2017 · 2 comments
Closed

Regression from 0.2.0, symbol can't be demangled #73

alexcrichton opened this issue Mar 27, 2017 · 2 comments
Labels
bug

Comments

@alexcrichton
Copy link

Discovered through the test suite of backtrace-rs it looks like the symbol _ZN5space20templated_trampolineIPFvvEEEvT_ is no longer demangled as void space::templated_trampoline<void (*)()>(void (*)()) I believe?
@fitzgen fitzgen added the bug label Mar 27, 2017
@fitzgen
Copy link
Member

fitzgen commented Mar 27, 2017

Thanks for the bug report!

@fitzgen
Copy link
Member

fitzgen commented Nov 8, 2017

Fixed in 0.2.6

@fitzgen fitzgen closed this as completed Nov 8, 2017
@ChrisDenton ChrisDenton mentioned this issue Jan 30, 2025
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this issue Feb 7, 2025
@jieyouxu @Pyr0de
tests: port backtrace's cpp_smoke_test as a run-make test
2387495 
This test exercises the `backtrace` submodule included under the
`library/` tree, which should be the `backtrace` that is used and thus
transitively shipped with the standard library.

The `cpp_smoke_test` was disabled in the `backtrace` repo many years
ago. This is seemingly because the test failed years ago due to C++
symbol demangling troubles in `cpp_demangle` (which are now fixed; see
<gimli-rs/cpp_demangle#73>).

Co-authored-by: Pyrode <[email protected]>
jieyouxu added a commit to jieyouxu/rust that referenced this issue Feb 7, 2025
@jieyouxu @Pyr0de
tests: port backtrace's cpp_smoke_test as a run-make test
224f901 
This test exercises the `backtrace` submodule included under the
`library/` tree, which should be the `backtrace` that is used and thus
transitively shipped with the standard library.

The `cpp_smoke_test` was disabled in the `backtrace` repo many years
ago. This is seemingly because the test failed years ago due to C++
symbol demangling troubles in `cpp_demangle` (which are now fixed; see
<gimli-rs/cpp_demangle#73>).

Note that this test is disabled on Windows MSVC because I couldn't get
it to work locally:

- At MSVC `-O1`, the test fails because there are no backtrace symbols.
- At MSVC `-O0`, the test fails because both the C++ templated
  trampolined symbol has a different signature (w/ a `__cdecl`) and also
  `cpp_trampoline` is missing.

Co-authored-by: Pyrode <[email protected]>
jieyouxu added a commit to jieyouxu/rust that referenced this issue Feb 7, 2025
@jieyouxu @Pyr0de
tests: port backtrace's cpp_smoke_test as a run-make test
7bb88c2 
This test exercises the `backtrace` submodule included under the
`library/` tree, which should be the `backtrace` that is used and thus
transitively shipped with the standard library.

The `cpp_smoke_test` was disabled in the `backtrace` repo many years
ago. This is seemingly because the test failed years ago due to C++
symbol demangling troubles in `cpp_demangle` (which are now fixed; see
<gimli-rs/cpp_demangle#73>).

Note that this test is disabled on Windows MSVC because I couldn't get
it to work locally:

- At MSVC `-O1`, the test fails because there are no backtrace symbols.
- At MSVC `-O0`, the test fails because both the C++ templated
  trampolined symbol has a different signature (w/ a `__cdecl`) and also
  `cpp_trampoline` is missing.

Co-authored-by: Pyrode <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @fitzgen