Skip to content

gguf-py : do not use internal numpy types #7472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

compilade
Copy link
Collaborator

Attempts to fix the problem described in #7234 (comment) by @LostRuins.

Should fix #7380

TODO

  • Test conversion with Numpy 1.22
  • Test conversion with Numpy 1.17, as in pyproject.toml

@compilade compilade added bugfix fixes an issue or bug Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix python python script changes labels May 22, 2024
@mofosyne mofosyne requested review from slaren and Galunid May 25, 2024 15:45
@compilade compilade merged commit 7d0e23d into master Jul 9, 2024
11 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 13, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 13, 2024
mccoylstevens pushed a commit to mccoylstevens/llama.cpp that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fixes an issue or bug python python script changes Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert-hf-to-gguf.py fails PR #7234
2 participants