-
Notifications
You must be signed in to change notification settings - Fork 11.8k
SYCL: Add non contiguous support in RMS_NORM and NORM kernels #13611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
It now seems to pass with ne[0] = 1920
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you able to measure the impact on performance for this change? If it has one we may want to introduce different paths for contiguous and non-contiguous cases.
I'll try to check on my side for some relevant sizes at some point.
This reverts commit 43be2d6.
ggml-ci
4f9b1bc
to
d5d39b5
Compare
Doesn't seem much different from master: [llama.cpp][master]$ build/bin/llama-bench -ngl 99 -m ~/Downloads/Weights/pythia-1.4b-q4_0.gguf
build: 92ecdcc (5423) [llama.cpp][sycl/non_cont_norms]$ build/bin/llama-bench -ngl 99 -m ~/Downloads/Weights/pythia-1.4b-q4_0.gguf
build: This PR |
Added non contiguous support in RMS_NORM and NORM kernels.
test-backend-ops
seems to pass with this change.Edit: restored logic for handling multi subgroup correctly which was not tested by test-backend-ops