feat(browser): Track measure detail as span attributes #16240
+197
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
mydea and
andreiborza
and removed request for
a team
|
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. |
size-limit report 📦
|
mydea
reviewed
May 9, 2025
| attributes[`sentry.browser.measure.detail.${key}`] = value as SpanAttributeValue; | ||
| } else { | ||
| try { | ||
| // This is user defined so we can't guarantee it's serializable |
There was a problem hiding this comment.
l: Can we instead just wrap the whole block inside of if (entry.detail) in a try-catch, maybe slightly less redundant?
mydea
approved these changes
May 9, 2025
allista
reviewed
May 9, 2025
| // https://developer.mozilla.org/en-US/docs/Web/API/Performance/measure#detail | ||
| if (entry.detail) { | ||
| // Handle detail as an object | ||
| if (typeof entry.detail === 'object') { |
There was a problem hiding this comment.
I would also ask to support arrays of primitives, here and as object props 🙏
Listing some things in spans is very useful, and SpanAttributeValue supports this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #16237
The SDK automatically instruments the
performance.measureAPI, but doesn't supportdetail, which is the way you can attach arbitrary data toperformance.measure. Given you can seedetailsin browser dev-tools, we should probably support it in the same way in Sentry.https://developer.mozilla.org/en-US/docs/Web/API/Performance/measure
detail docs: https://developer.mozilla.org/en-US/docs/Web/API/PerformanceMeasure/detail
Detail is completely arbitrary, so we have to take care before parsing it. I have added tests accordingly.