feat(cloudflare): Improve http span data #16232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
lforst and
RulaKhaled
and removed request for
a team
size-limit report 📦
|
AbhiPrasad
force-pushed
the
abhi-improve-cloudflare-context
branch
from
0aa0999 to
52b7884
Compare
AbhiPrasad
commented
May 8, 2025
| */ | ||
| export function getHttpSpanDetailsFromUrlObject( | ||
| urlObject: URLObject | undefined, | ||
| kind: 'server' | 'client', |
There was a problem hiding this comment.
I know during our bikeshedding session we said we wanted to get rid of this, but I had to add it back so that we could generate the name correctly.
See the getHttpSpanNameFromUrlObject implementation.
AbhiPrasad
commented
May 8, 2025
| @@ -53,7 +61,7 @@ export function isURLObjectRelative(url: URLObject): url is RelativeURL { | |||
| * @returns The parsed URL object or undefined if the URL is invalid | |||
| */ | |||
| export function parseStringToURLObject(url: string, urlBase?: string | URL | undefined): URLObject | undefined { | |||
| const isRelative = url.startsWith('/'); | |||
| const isRelative = url.indexOf('://') <= 0 && url.indexOf('//') !== 0; | |||
There was a problem hiding this comment.
This check is now much more robust. I've added way more tests for this as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While helping debug work in https://github.com/getsentry/sentry-mcp, I noticed that we didn't attach
url.pathto the http fetch spans, which made using the trace explorer harder to use.This PR updates the cloudflare http instrumentation (fetch handlers for regular workers and durable objects) to use a new
getHttpSpanDetailsFromUrlObjectabstraction I built.getHttpSpanDetailsFromUrlObjectreturns the http span name and it's associated attributes, taking care to handle source, route names, and handling both relative and full URLs.This is related to all the #15767 work I've been doing.