-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(react-router): Create low quality transactions filter for react router #16219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-router): Create low quality transactions filter for react router #16219
Conversation
packages/react-router/src/server/lowQualityTransactionsFilterIntegration.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
Not sure, something to look at in a follow up, but does the logic we have for nuxt make sense where we ignore all requests to files with ending (e.g. GET asdasd.png
)? 🤔 but this is something to iterate on :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🥇
@mydea good point but we need to make sure not to filter e.g. /some/route.data as we depend on that atm 👍 |
Filter out server side noisy transactions triggered by http integration from react-router. Fixes: #16161