fix: Vercel ai ESM patching
#16152
Merged
fix: Vercel ai ESM patching
#16152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
timfish
force-pushed
the
fix/vercel-ai-iitm-issue
branch
2 times, most recently
from
513e696 to
f9b14f4
Compare
timfish
force-pushed
the
fix/vercel-ai-iitm-issue
branch
from
f9b14f4 to
d48395d
Compare
timfish
changed the title
ai import-in-the-middle patchingai ESM patching
Lms24
approved these changes
Apr 29, 2025
|
hmm look slike CI is stuck for some reason 🤔 @timfish mind rebasing to see if this fixes CI? thx! |
|
Not sure how this made it onto master. Maybe a caching issue? |
|
hmm maybe 🤔 we did enable import sorting again via #16134, so this is likely related |
|
No idea why remix-hydrogen e2e test is failing 🤷♂️ |
|
hmm this looks unrelated indeed. Will take a look update: yeah, it's also failing in other PRs. We'll fix this |
|
CI should be unblocked -- @timfish please rebase once more, thx! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ESM patching you need to retain the original module and just overwrite the exports you want to wrap. This usually works for CJS too but unfortunately, the CJS exports of
aionly have getters and no setters so this route is not possible.This PR changes the patching so that it works slightly differently for ESM and CJS. The original code that outputs a newly created object is retained for CJS but for ESM we use the preferred route of replacing the required exports.
To detect whether the module we're patching is an ES module we check
Object.prototype.toString.call(moduleExports) === '[object Module]'which is documented here.This PR also adds an ESM test for
ai.