-
Notifications
You must be signed in to change notification settings - Fork 229
Add initial logger implementation #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1010 +/- ##
==========================================
+ Coverage 85.12% 85.42% +0.29%
==========================================
Files 53 55 +2
Lines 5276 5487 +211
==========================================
+ Hits 4491 4687 +196
- Misses 640 655 +15
Partials 145 145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw this was in progress so did a preliminary review! Do you mind also adding some examples in the PR description of how log should be configured and used with this PR?
Thanks for the review Abhi. Will also add examples, nice catch. |
For
instead we should emit something like
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once https://github.com/getsentry/sentry-go/pull/1010/files/d40ff0a677f0d3d3b54ba2a0ae594ce85837d15d#r2086096970 is addressed, we can get this merged
Closes #1000.
Example usage of logger