Skip to content

feat(cloudflare): Add docs for durable objects instrumentation #13626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

AbhiPrasad
Copy link
Member

DESCRIBE YOUR PR

Documents getsentry/sentry-javascript#15975 / getsentry/sentry-javascript#16180

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@AbhiPrasad AbhiPrasad requested a review from a team May 7, 2025 15:54
@AbhiPrasad AbhiPrasad self-assigned this May 7, 2025
@AbhiPrasad AbhiPrasad requested review from s1gr1d and RulaKhaled and removed request for a team May 7, 2025 15:54
Copy link

vercel bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:54pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 8, 2025 1:54pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview May 8, 2025 1:54pm

Copy link

codecov bot commented May 7, 2025

Bundle Report

Changes will increase total bundle size by 240 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.16MB 246 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.48MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/bZeS8t3eWrPJ_cFO2aNXq/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/bZeS8t3eWrPJ_cFO2aNXq/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/ZiAfIBhG-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/ZiAfIBhG-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 85 bytes 391.52kB 0.02%
../app/platform-redirect/page.js.nft.json 85 bytes 391.44kB 0.02%
../app/sitemap.xml/route.js.nft.json 85 bytes 389.41kB 0.02%

dcramer added a commit to getsentry/sentry-mcp that referenced this pull request May 7, 2025
…ion (#165)

Durable objects instrumentation support was added in
[9.16.0](https://github.com/getsentry/sentry-javascript/releases/tag/9.16.0)
of the JS SDK. This PR upgrades `sentry-mcp` to get instrumented with
durable objects.

Docs PR for durable objects is here:
getsentry/sentry-docs#13626.

In `packages/mcp-cloudflare/src/server/lib/mcp-transport.ts` I had to
comment out the `wrapMcpServerWithSentry` usage, because this breaks
locally with miniflare. We're following up with the cloudflare team
about this (more details here in linear:
https://linear.app/getsentry/issue/JS-398/9150-breaks-cloudflare-sdk-usage-in-sentry-mcp#comment-7ce26edb).
When we fix this, we'll come back and re-enable it.

`9.16.0` also added support for logs in the Cloudflare SDK, so I enabled
that, and added the `consoleLoggingIntegration` (integration is optional
while logs is experimental in the SDK) to flush logs from `console.X`
calls to Sentry.

---------

Co-authored-by: David Cramer <[email protected]>
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AbhiPrasad AbhiPrasad force-pushed the abhi-durable-objects-cloudflare branch from d79d8e9 to e18c9c8 Compare May 8, 2025 13:38
@AbhiPrasad AbhiPrasad merged commit d525cb9 into master May 8, 2025
11 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-durable-objects-cloudflare branch May 8, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants