ENH: support mask for missing values when writing data / support writing pandas nullable dtypes #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing pandas nullable dtypes
brendan-ward
reviewed
Apr 2, 2023
brendan-ward
reviewed
Apr 2, 2023
|
Also, please add entry to the changelog. |
Co-authored-by: Brendan Ward <[email protected]>
Co-authored-by: Brendan Ward <[email protected]>
brendan-ward
approved these changes
Apr 2, 2023
There was a problem hiding this comment.
Other than suggestion re: adding a comment, this looks great. Thanks @jorisvandenbossche !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #219
The required change in cython to suppport passing a mask is actually quite limited, it's mostly new code in geopandas.py to get the proper data/mask.