Pin rust version to 1.86.0 due to cairo_vm incompatibility
#3352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciszekjob
approved these changes
May 16, 2025
ksew1
approved these changes
May 16, 2025
cptartur
merged commit e04cf7a
into
disable-free-voyager-provider
23 of 26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
Interface of
is_multiple_ofchanged in rust 1.87.0. This is a know regression that won't be resolved, see rust-lang/rust#140020Due to that,
cairo_vmno longer compiles on later rust version. Until they upgrade and we upgrade our version ofcairo_vm, then we have to stay at rust 1.86.0Issue to remove the pinned version #3351
Checklist
CHANGELOG.md