Improve check for F18 error stop #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ifort 21.1 BETA 20200827 compiles F18 error stop syntax but does not propagate the error code correctly
|
BTW, I checked our code (https://gitlab.tp.nt.uni-siegen.de/whizard/public) with ifort 21.1 BETA 20200827, and the new compiler has several problems, apparently with deallocation and garbage collection. I'm preparing a reproducer for at least one issue for Intel, but roughly 80% of our test suite fails with the new ifort, so I doubt that this is only one problem. |
milancurcic
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Fortran 2018 error stop check by running the example and checking for a correctly reported return code from the program.
The current check gives a false positive result for
ifort21.1 BETA 20200827, which compiles F18 error stop syntax but does not propagate the error code correctly. Since this is probably a bug I reported this upstream as well:https://community.intel.com/t5/Intel-Fortran-Compiler/Fortran-2018-error-stop/m-p/1234424#M153065