Skip to content

debug_logger: add log_debug to logger #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

jvdp1
Copy link
Member

@jvdp1 jvdp1 commented Dec 4, 2020

Following the discussion in #254, I propose to add a subroutine call log_debug with the following API:

Description

Writes the string message to self % log_units with optional additional text.

Syntax

call self % log_debug( message [, module, procedure ] )

Behavior

If time stamps are active, a time stamp is written, followed
by module and procedure if present, and then
message is written with the prefix 'DEBUG: '.

QUESTION: Is this API OK? Or should it be more similar to the API of log_error with stat and errmsg?

@wclodius2
Copy link
Contributor

I think the API is good. In particular I would not add a stat or errmsg.

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me as well.

@jvdp1
Copy link
Member Author

jvdp1 commented Dec 9, 2020

Thank you for the review. I'll merge it and submit the next PR mentioned in #254

@jvdp1 jvdp1 merged commit d0d927d into fortran-lang:master Dec 9, 2020
@jvdp1 jvdp1 deleted the debug_logger branch December 22, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants