specified order of attributes #167 #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JHenneberg
changed the title
certik
approved these changes
Apr 6, 2020
milancurcic
approved these changes
Apr 6, 2020
jvdp1
approved these changes
Apr 6, 2020
Co-Authored-By: Milan Curcic <[email protected]>
Co-Authored-By: Milan Curcic <[email protected]>
JHenneberg
commented
Apr 7, 2020
|
Merging into master, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets discuss if this is need or giving to much overhead. For now there is positive (@jvdp1 ) and negative (@certik ) feedback.
In my opinion a standard library should not only provide functionalty, it also should give example how to use a programming language in an elegant way. We decided already in the STYLE_GUIDE.md to include indentation and whitespaces conventions which have of course bigger impact but specifiying that at an end of a scope there should be a closing statment is quite a minor thing so why to draw a line when specifiying the order of attritbutes?