Skip to content

Spec for error_stop and check #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 30, 2020
Merged

Spec for error_stop and check #166

merged 9 commits into from
Mar 30, 2020

Conversation

jvdp1
Copy link
Member

@jvdp1 jvdp1 commented Mar 27, 2020

@milancurcic Here is a first draft for the specs about error_stop and check.

@jvdp1 jvdp1 requested a review from milancurcic March 27, 2020 15:23
milancurcic
milancurcic approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I left a few comments.

jvdp1
jvdp1 commented Mar 27, 2020
View reviewed changes
@jvdp1
Copy link
Member Author

jvdp1 commented Mar 27, 2020

Thank you @milancurcic and @everythingfunctional for your comments. They are now integrated.

certik
certik approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good. I left a minor comment.

@certik
Copy link
Member

certik commented Mar 27, 2020

Looks great. +1 to merge as is.

@jvdp1
Copy link
Member Author

jvdp1 commented Mar 30, 2020

Thank you for your comments. I will merge it as is.

@jvdp1 jvdp1 merged commit 6661975 into fortran-lang:master Mar 30, 2020
@jvdp1 jvdp1 deleted the spec_check branch June 9, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everythingfunctional everythingfunctional everythingfunctional left review comments

@certik certik certik approved these changes

@milancurcic milancurcic milancurcic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jvdp1 @certik @everythingfunctional @milancurcic