Separate build targets from model structure #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backend simplified to use compiler and linker flags on per target basis. Removes redundant link_flags field in model structure. Fixes benign issue with duplicated link flags.
awvwgk
approved these changes
Mar 2, 2021
There was a problem hiding this comment.
Thanks this is a useful refactoring.
In the long term we should aim for a solution which doesn't require to generates in a context where they are not required, i.e. the installer. Does the model know without creating the targets about the executables in the current project?
Thanks for reviewing, yes I agree with you on this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed previously the list of build targets (
build_target_t) is specific to the native backend and hence doesn't strictly belong in the model structure (which is ideally backend-independent).This PR separates the list of build targets from the model structure and therefore provides a better distinction between the package representation and the fpm backend. In particular this refactoring removes some existing complication and redundancy in the treatment of compiler and linker flags which are now passed to the backend on a per target basis. As a result the backend is further simplified and importantly this paves the way for #112 (managing flags) and #358 (Improve support for include statements).