-
Notifications
You must be signed in to change notification settings - Fork 68
Expand do loops with cycle and exit #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This looks great @Irvise, definitely an improvement! |
Thanks @Irvise, looks great! |
I agree, great addition, thank you! #build_preview |
This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/116/ |
I suppose this marks the end of the changes. Please, check More comments are welcome. |
Apologies for the delay @Irvise, I will review this today with specific feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this @Irvise; I only have a few minor suggestions, but otherwise it all looks good to me! 👍
One thing I have not included in my suggestions is that it may be better to move the do concurrent
section to the end since it is a more advanced concept than the loop control statements.
Co-authored-by: Laurence Kedward <[email protected]>
Co-authored-by: Laurence Kedward <[email protected]>
Co-authored-by: Laurence Kedward <[email protected]>
Co-authored-by: Laurence Kedward <[email protected]>
Co-authored-by: Laurence Kedward <[email protected]>
Co-authored-by: Laurence Kedward <[email protected]>
Co-authored-by: Laurence Kedward <[email protected]>
Co-authored-by: Laurence Kedward <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
#build_preview |
This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/116/ |
I have moved I would say LGTM. Thanks @LKedward for the improvements! |
Great stuff! 👍 (Sorry for the conflicts!) |
Co-authored-by: Laurence Kedward <[email protected]>
#build_preview |
This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/116/ |
One last thing @Irvise, some of the indentation is rendering incorrectly for the cycle example, and the tagged nested loop example; the |
#build_preview |
This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/116/ |
I will merge as no other comments. Great addition @Irvise, thanks! |
#delete_preview |
The preview build for this PR has now been deleted. |
This is a minor expansion of the tutorial page on control flow.
I am not entirely happy with the current result, but I cannot figure out why (probably because it is very short when compared to the rest of the file). So any comments on these changes are welcome.
I expect to continue expanding this with
do concurrent
and tags. However, some initial feedback will be beneficial.This pull is related to the discussion in fortran-lang/webpage#68.
Regards,
Fernando