Skip to content

Expand do loops with cycle and exit #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 13, 2020
Merged

Conversation

Irvise
Copy link
Contributor

@Irvise Irvise commented Jul 2, 2020

This is a minor expansion of the tutorial page on control flow.

I am not entirely happy with the current result, but I cannot figure out why (probably because it is very short when compared to the rest of the file). So any comments on these changes are welcome.

I expect to continue expanding this with do concurrent and tags. However, some initial feedback will be beneficial.

This pull is related to the discussion in fortran-lang/webpage#68.

Regards,

Fernando

@LKedward LKedward marked this pull request as draft July 2, 2020 11:05
@LKedward
Copy link
Member

LKedward commented Jul 2, 2020

This looks great @Irvise, definitely an improvement!
Thanks 👍

@certik
Copy link
Member

certik commented Jul 2, 2020

Thanks @Irvise, looks great!

@milancurcic
Copy link
Member

I agree, great addition, thank you!

#build_preview

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/116/

@Irvise
Copy link
Contributor Author

Irvise commented Jul 3, 2020

I suppose this marks the end of the changes.

Please, check do concurrent since I am not well versed with it and I may have committed some mistakes.

More comments are welcome.

@Irvise Irvise marked this pull request as ready for review July 3, 2020 11:40
@LKedward
Copy link
Member

LKedward commented Jul 6, 2020

Apologies for the delay @Irvise, I will review this today with specific feedback.

Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this @Irvise; I only have a few minor suggestions, but otherwise it all looks good to me! 👍
One thing I have not included in my suggestions is that it may be better to move the do concurrent section to the end since it is a more advanced concept than the loop control statements.

Irvise and others added 8 commits July 7, 2020 11:26
Co-authored-by: Laurence Kedward <[email protected]>
Co-authored-by: Laurence Kedward <[email protected]>
Co-authored-by: Laurence Kedward <[email protected]>
Co-authored-by: Laurence Kedward <[email protected]>
Co-authored-by: Laurence Kedward <[email protected]>
Co-authored-by: Laurence Kedward <[email protected]>
Co-authored-by: Laurence Kedward <[email protected]>
@LKedward

This comment has been minimized.

@LKedward

This comment has been minimized.

@LKedward
Copy link
Member

LKedward commented Jul 7, 2020

#build_preview

@github-actions
Copy link

github-actions bot commented Jul 7, 2020

This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/116/

@Irvise
Copy link
Contributor Author

Irvise commented Jul 7, 2020

I have moved do concurrent to the bottom and I have updated some comparison symbols to a more "modern" standard.

I would say LGTM. Thanks @LKedward for the improvements!

@LKedward
Copy link
Member

LKedward commented Jul 7, 2020

Great stuff! 👍 (Sorry for the conflicts!)
#build_preview

Co-authored-by: Laurence Kedward <[email protected]>
@Irvise
Copy link
Contributor Author

Irvise commented Jul 7, 2020

#build_preview

@github-actions
Copy link

github-actions bot commented Jul 7, 2020

This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/116/

@LKedward
Copy link
Member

LKedward commented Jul 8, 2020

One last thing @Irvise, some of the indentation is rendering incorrectly for the cycle example, and the tagged nested loop example; the end if is not aligned with the opening if and the loop body has extra indentation. Can you make sure you're not using any tab characters, only spaces?

@Irvise
Copy link
Contributor Author

Irvise commented Jul 8, 2020

#build_preview

@github-actions
Copy link

github-actions bot commented Jul 8, 2020

This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/116/

@LKedward LKedward requested a review from milancurcic July 8, 2020 18:17
@LKedward
Copy link
Member

I will merge as no other comments. Great addition @Irvise, thanks!

@LKedward LKedward merged commit dfe0e7b into fortran-lang:master Jul 13, 2020
@LKedward
Copy link
Member

#delete_preview

@github-actions
Copy link

The preview build for this PR has now been deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants