Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add docs for helpful commands to fix format #8171

Merged
merged 2 commits into from
Mar 19, 2019

Conversation

liyuqian
Copy link
Contributor

No description provided.

@cyanglaz
Copy link
Contributor

LGTM, but wait for @cbracken to approve.

@liyuqian
Copy link
Contributor Author

@cbracken updated according to your suggestion 😃

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liyuqian liyuqian merged commit d764b69 into flutter:master Mar 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Mar 20, 2019
flutter/engine@96ad0c8...a1dcb2e

git log 96ad0c8..a1dcb2e --no-merges --oneline
a1dcb2e [ios] Set contentsScale before we commit CATransaction (flutter/engine#8218)
fa1931f Send macOS keyboard data to the engine (flutter/engine#8219)
45f69ac Plumb a reference of PlatformViewsController and AccessibilityBridge to each other (flutter/engine#8208)
7cbbdb4 libtxt: more accurate tracking of run positioning and width for justified text (flutter/engine#8214)
1728103 Add a build dependencies script for Linux desktop (flutter/engine#8160)
d764b69 Add docs for helpful commands to fix format (flutter/engine#8171)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Mar 20, 2019
flutter/engine@96ad0c8...6a8a45f

git log 96ad0c8..6a8a45f --no-merges --oneline
6a8a45f Have the AccessibilityBridge attach/detach itself to the (flutter/engine#8229)
45b19e4 Roll src/third_party/skia ba91f65f2070..7e2c0614a2fd (13 commits) (flutter/engine#8228)
1dbd204 Moved io.flutter.embedding.engine.android package to io.flutter.embedding.android (flutter/engine#8221)
bb35436 Roll src/third_party/dart 70e3e67dd7..5e9df35a57 (45 commits)
3b19a4d Removed dart_plugin_tag from DEPS
d9b6629 Roll src/third_party/skia 4273a150f84d..ba91f65f2070 (6 commits) (flutter/engine#8225)
e88573a Roll src/third_party/skia d7d93001ead2..4273a150f84d (1 commits) (flutter/engine#8224)
be9067c Roll src/third_party/skia 37a9294d2eb9..d7d93001ead2 (2 commits) (flutter/engine#8223)
ee4abba Roll src/third_party/skia 2894d13a0d9b..37a9294d2eb9 (1 commits) (flutter/engine#8222)
3496156 Roll src/third_party/skia dd0544078d05..2894d13a0d9b (33 commits) (flutter/engine#8220)
a1dcb2e [ios] Set contentsScale before we commit CATransaction (flutter/engine#8218)
fa1931f Send macOS keyboard data to the engine (flutter/engine#8219)
45f69ac Plumb a reference of PlatformViewsController and AccessibilityBridge to each other (flutter/engine#8208)
7cbbdb4 libtxt: more accurate tracking of run positioning and width for justified text (flutter/engine#8214)
1728103 Add a build dependencies script for Linux desktop (flutter/engine#8160)
d764b69 Add docs for helpful commands to fix format (flutter/engine#8171)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
RBogie pushed a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
@liyuqian liyuqian deleted the format_help branch May 23, 2019 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants