This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland: Update Color to do all calculations with floating point components #55231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
force-pushed
the
reland-e24aa4d1710f4b30c7351cd7805aabfa00c564e1
branch
2 times, most recently
from
32e9eaf to
9cb9cc5
Compare
…lutter#54981) This transforms the rest of Color to use the floating point parameters. This will likely break existing tests very subtly. For example, colors will be slightly different in golden tests if `lerp` was ever used. issue: flutter/flutter#127855 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
gaaclarke
force-pushed
the
reland-e24aa4d1710f4b30c7351cd7805aabfa00c564e1
branch
from
9cb9cc5 to
c0cce1a
Compare
|
I double checked the zulip tests locally, everything looks good. |
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 23, 2024
9 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 23, 2024
chingjun
added a commit
to chingjun/packages
that referenced
this pull request
Sep 25, 2024
In flutter/engine#55231, the implementation of `Color.toString()` has changed. Update the test to not depend on the exact implementation.
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 25, 2024
In flutter/engine#55231, the implementation of `Color.toString()` has changed. Update the test to not depend on the exact implementation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for revert: Broke customer tests
Reland depends on flutter/flutter#155113
This transforms the rest of Color to use the floating point parameters. This will likely break existing tests very subtly. For example, colors will be slightly different in golden tests if
lerpwas ever used.issue: flutter/flutter#127855
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.