Skip to content

Context menu disappear after unpressing right button in Firefox #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brezetsky opened this issue May 24, 2017 · 5 comments
Closed

Context menu disappear after unpressing right button in Firefox #16

brezetsky opened this issue May 24, 2017 · 5 comments
Assignees
@fkhadra
Labels
bug

Comments

@brezetsky
Copy link

Right button press and hold - menu appears.
Right button unpress - menu disappears(for Mozilla).

Works for Chrome.
@fkhadra fkhadra self-assigned this May 24, 2017
@fkhadra fkhadra added the bug label May 24, 2017
@fkhadra
Copy link
Owner

fkhadra commented May 24, 2017

I just noticed that firefox trigger a click event on right click up ...

fkhadra added a commit that referenced this issue May 24, 2017
@fkhadra
Fix Issue #16
db81d00
@fkhadra
Copy link
Owner

fkhadra commented May 24, 2017

@brezetsky fixed. I need to test on safari but I don't have a mac at work

@fkhadra fkhadra closed this as completed May 24, 2017
@brezetsky
Copy link
Author

Thanks.
Works for me in safari too.

@C3PablO
Copy link
Contributor

C3PablO commented Jun 1, 2018

this still not working in Safari if you right-click using ctrl + trackpad-click. I can reproduce it on the demo page

@C3PablO
Copy link
Contributor

C3PablO commented Jun 1, 2018

Is the same issue that Firefox had before but in this case e.button === 0 instead 2 so it doesn't enter the conditional to not close the menu

C3PablO pushed a commit to iconik-io/react-contexify that referenced this issue Jun 1, 2018
Ref fkhadra#16 - prevent menu to dissapear in Safari/Firefox
6cb3a4f
C3PablO pushed a commit to iconik-io/react-contexify that referenced this issue Jun 28, 2018
Ref fkhadra#16 - prevent menu to dissapear in Safari
2efb1bb
C3PablO pushed a commit to iconik-io/react-contexify that referenced this issue Jun 28, 2018
Ref fkhadra#16 - prevent menu to dissapear in Safari
c4ab745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkhadra fkhadra

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@C3PablO @fkhadra @brezetsky