Skip to content

feat: add react query example #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ruslan4432013
Copy link
Contributor

This PR added example of usage React Query with FSD

Copy link

netlify bot commented May 24, 2024

Deploy Preview for pr-fsd ready!

Name Link
🔨 Latest commit e0d6b55
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/66560926b7514d0007a6d9c7
😎 Deploy Preview https://deploy-preview-673--pr-fsd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо, что оформил ПРчик! Русская версия выглядит хорошо, как мы, в целом, уже раньше и обсуждали, только местами есть опечаточки (типа "Полезный ссылки").

С английской версией немного сложнее :D В русской версии местами немного сложная структура предложений, и после перевода на английский смысл становится очень трудно уловить. Самый яркий пример — раздел CodeGeneration (я бы, кстати, сделал два слова, не сливал в одно).

There are tools for automatic code generation that are less flexible than those which can be configured as described above.

Это предложение предлагаю переписать вот так:

There are tools that can generate API code for you, but they are less flexible than the manual approach described above.

И в целом, предлагаю скормить этот текст какой-нибудь хорошей LLM-ке и попросить исправить ошибки и упростить язык, а потом проверить через LanguageTool (англ) и Главред (рус)

@ruslan4432013 ruslan4432013 force-pushed the feature/add-react-query-example branch 4 times, most recently from 058535f to 9e0315b Compare May 26, 2024 10:36
@ruslan4432013 ruslan4432013 force-pushed the feature/add-react-query-example branch from 9e0315b to 9300cdf Compare May 26, 2024 10:39
@illright illright merged commit 3165fe0 into feature-sliced:master May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants