Skip to content

Replace the graphic on the Layers reference page #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2023
Merged

Conversation

illright
Copy link
Member

Background

The Layers reference page doesn't tell anything about the fact that layers are just folders. This updated graphic is meant to reflect the file-system nature of layers.

Changelog

  1. Changed the graphic to the new one
  2. Added a descriptive alt text to the graphic
  3. Added styles to support themed images with #light-mode-only and #dark-mode-only URL modifiers

Before:
telegram-cloud-photo-size-2-5431876295400215458-y

After:
image

image

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for pr-fsd ready!

Name Link
🔨 Latest commit 432904e
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/646c6b8f93f6b20008ff613a
😎 Deploy Preview https://deploy-preview-583--pr-fsd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@illright illright enabled auto-merge (squash) May 22, 2023 19:36
@@ -15,9 +15,10 @@ On this page, a _module_ refers to an internal module in the application — a f

Every layer carries special semantic meaning to help you determine how much responsibility you should allocate to a module in your code. The names and meanings of layers are standardized across all projects built with Feature-Sliced Design.

There are 7 layers in total, arranged from most responsibility and dependency to least:
There are **7 layers** in total, arranged from most responsibility and dependency to least:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Добавь еще в рус версию пож

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а, блин, забыл)

Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for merge 🔥

@illright illright merged commit 510f00a into master May 23, 2023
@illright illright deleted the ref-layers-graphic branch May 23, 2023 10:05
@azinit
Copy link
Member

azinit commented May 23, 2023

@illright could u please merge master into current branch after recent changes? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants