Skip to content

Refactor/knowledge types #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 10, 2023
Merged

Refactor/knowledge types #551

merged 7 commits into from
Feb 10, 2023

Conversation

xxtereshko
Copy link
Contributor

Background

Changelog

See diff.

@netlify
Copy link

netlify bot commented Jan 24, 2023

Deploy Preview for pr-sliced ready!

Name Link
🔨 Latest commit 85c4094
🔍 Latest deploy log https://app.netlify.com/sites/pr-sliced/deploys/63d6a3aa665cc2000925299e
😎 Deploy Preview https://deploy-preview-551--pr-sliced.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

- **Fundamental knowledge**
Knowledge that practically does not change over time.
*Algorithms, computer science, the mechanisms of the YAP and its API, etc.*
### Fundamental knowledge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: why did you decide to use headings instead of a list?

In my opinion, this page should not exist in the form that it currently exists in, and instead it should be a part of a larger page discussing the benefits of FSD. With that in mind, I'd actually prefer to shorten this page as much as possible so that it wouldn't occupy too much space when it's merged into another page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can refactor itI think we can rewrite it when we paste it into another page. In general, lists with large items are harder to read.

Copy link
Member

@illright illright Jan 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree about the large lists. However, I think we can approach this from another direction by reducing the text content (I'd argue, without losing too much informational value).

I took the liberty of experimenting and came up with this, what do you think about it?

image

I changed it back into a list and reworded the description of the third point to be shorter.

Text content of that edit for ease of further tweaking
* **Fundamental knowledge**  
  Knowledge that does not change much over time, such as algorithms, computer science, programming language mechanisms and its APIs.

* **Technology stack**  
  Knowledge of the set of technical solutions used in a project, including programming languages, frameworks, and libraries.

* **Project knowledge**  
  Knowledge that is specific to the current project and not valuable outside of it. This knowledge is essential for newly-onboarded developers to be able to contribute effectively.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduced the change, let me know if there's anything else you'd like to tweak, otherwise we can merge this

@xxtereshko xxtereshko requested review from illright and removed request for skrylnikov, sandrig and unordinarity January 28, 2023 16:12
@azinit azinit merged commit 14d8d2b into feature-sliced:master Feb 10, 2023
@xxtereshko xxtereshko deleted the refactor/knowledge-types branch February 19, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants