Skip to content

feat(intro): finish the proposed corrections to the intro page #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 1, 2022

Conversation

illright
Copy link
Member

Background

Closes #441, closes #442, closes #444

Changelog

  1. Described the core concepts of the methodology
  2. Added a decomposition example
  3. Added a migration strategy (shared by @unordinarity in the Telegram chat)

@netlify
Copy link

netlify bot commented Jul 27, 2022

Deploy Preview for pr-sliced ready!

Name Link
🔨 Latest commit e36e571
🔍 Latest deploy log https://app.netlify.com/sites/pr-sliced/deploys/62e3e3299b552e0008bb0eb3
😎 Deploy Preview https://deploy-preview-515--pr-sliced.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@illright illright requested a review from azinit July 27, 2022 17:06
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне в целом оч зашло, есть только toImprove)

Ждем что @unordinarity и @Rin-Akaia-eth накинут 😏

Comment on lines 34 to 40
1. **Shared** — reused functionality, detached from the specifics of the project/business.
2. **Entities** — business entities (e.g., user, product, order).
3. **Features** — user interactions, actions that bring business value to the user.
4. **Widgets** — compositional layer to combine entities and features into meaningful blocks.
5. **Pages** — compositional layer to construct full pages from entities, features and widgets.
6. **Processes** — complex inter-page scenarios (e.g., authentication).
7. **App** — app-wide settings, styles and providers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoughts: Было бы здорово в будущем из этого еще одну картинкку сделать, чтобы проще было воспринимать чем еще одно полотно тексто

Comment on lines +42 to +44
Then there are slices, which partition the code by business domain. This makes your codebase easy to navigate by keeping logically related modules close together. Slices cannot use other slices on the same layer, and that helps with high cohesion and low coupling.

Each slice, in turn, consists of segments. These are tiny modules that are meant to help with separating code within a slice by its technical purpose. The most common segments are `ui`, `model`, `api` and `lib`, but you can omit some or add more, as you see fit.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом гуд и развернуто, но было бы классно чуть "упростить" чтоль , как было до этого
Чтоб люди не офигевали еще больше после "слоев"/"слайсов"/"сегментов"

Но это так "на подумать" как улучшить, некрит
Мб у самого идеи будут тож)

@azinit
Copy link
Member

azinit commented Jul 28, 2022

@unordinarity @Rin-Akaia-eth @illright ping)

Co-authored-by: Rin.Akaia.eth <[email protected]>
Co-authored-by: Ilya Azin <[email protected]>
@illright
Copy link
Member Author

@azinit готово к мерджу?

@azinit
Copy link
Member

azinit commented Jul 31, 2022

@illright давай попзж еше гляну)
Но правки от @Rin-Akaia-eth внести бы, хотяб основные пж пж

@azinit
Copy link
Member

azinit commented Aug 1, 2022

@illright Вливаю спс!
Сможешь потом унифицировать под русский пож тоже Intro?
(чисто перевод, к тому что тут обсуждалось - придираться не будем 😏 )

@azinit azinit merged commit 7b7509d into master Aug 1, 2022
@azinit azinit deleted the feat/finish-intro branch August 1, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants